New Content - Implemented Your Shadow has images for AWoL

Bale

Bale

Minion
I made a new thread for this because I don't want this to get lost or confused since it is a change to AWoL since it originally rolled out.

KoLmafia is not recognzing Your Shadow as AWoL since it did not originally have an image. KoL has fixed that, so mafia now needs to adapt to the change.


Right now as a male Snake Oiler my shadow looks like...
http://127.0.0.1:60080/images/otherimages/shadows/200.gif

We'll need images for the rest of the classes/sexes. The wiki is not being helpful at finding them.
 
Also, it looks like the shadow is detected purely by monster name in consequences.txt. I wonder if we could instead do some more general match on name matching "^Shadow " and image matching "^otherimages/shadows/\d+\.gif$" (for future-proofing). I'll check to see what the patterns defined in consequences.txt are tested against.
 
Unrelated aside, it looks like there may be some typos in consequences.txt (unless those are typos in KoL) -- Banishing Shout and Staff of the Standalone Cheese both look for "curently banished".
 
heeheehee said:
Also, it looks like the shadow is detected purely by monster name in consequences.txt. I wonder if we could instead do some more general match on name matching "^Shadow " and image matching "^otherimages/shadows/\d+\.gif$" (for future-proofing). I'll check to see what the patterns defined in consequences.txt are tested against.
Click to expand...

Doesn't look like it; name is literally the monster name. I don't think it's worth incurring the cost of a regex search every encounter just to save us a little bit of effort down the road.

Either way, I can certainly add the WoL shadows (and stop caching fake images). Added in r16803, mostly untested.

edit: I can check Cow Puncher when I hit the shadow after rollover.
 
I'll see the Beanslinger shadow after rollover. Not that I will run my turns right then, but, tomorrow, at least.
 
Last edited:
Unless I've misinterpreted your intentions entirely, I don't see how providing us with a loopback link to an image as an example of what you're seeing could be helpful.
 
Code: 
[838] Tower Level 5
Encounter: Shadow Beanslinger
Round 0: Veracity wins initiative!
Round 1: Veracity uses the red pixel potion!
Round 2: You gain 109 hit points
Round 2: You lose 231 hit points

[color=green]> ash last_monster()[/color]

Returned: Your Shadow
id => 210
...
So far, so good.
 
You must log in or register to reply here.
Back
Top