Bug "Refresh menu" menu item broken under "Scripts"

Linknoid

Member
When you hit Refresh menu, it doesn't do anything. The attached patch fixes the problem.

In the current version, it refreshes the underlying list of scripts, but it doesn't refresh the menu. This patch makes it refresh the menu in the UI as well.
 

Attachments

  • kolmafia-RefreshMenu.patch
    871 bytes · Views: 3

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
Staff member
Would you like to make a PR on GitHub? We don't really take patches anymore
 

Linknoid

Member
I spent over 2 hours trying to figure out pull requests, and I still don't get it. Here's the short version:

1. In GitHub I selected "Import repository", and imported from https://github.com/kolmafia/kolmafia.git which took like an hour.
2. Then I committed my change locally, and pushed it out to my new copy of the repository at https://github.com/Linknoid/KoLmafia.git.
3. I went to kolmafia/kolmafia and selected "New pull request", and the clicked "compare across forks". It has a bunch of forks listed, but not the one I just created.

At this point I'm lost what to do. I don't know what I'm doing wrong. Are there any instructions on how to do this correctly? I understand git, but I don't get GitHub. All my previous interactions with GitHub I managed through my local git.
 

Ryo_Sangnoir

Developer
Staff member
Instead of importing a repository, you want to fork the existing repository. In https://github.com/kolmafia/kolmafia, near the top right, there is a "fork" button. Click it.

1664096737775.png

This will create a repository at https://github.com/Linknoid/kolmafia (or would have done, if you hadn't imported a repository there. You might want to delete your existing repository).

Then if you commit your change locally to your fork, and make a pull request and compare across forks, you should see the fork you just created.
 

heeheehee

Developer
Staff member
(We also have a CONTRIBUTING.md guide in the root of the repo, which I've just linked on the wiki page for patching. That said, it's evidently missing a few steps around setting up the fork, so I've sent a PR with a brief quickstart guide.)
 

gausie

D̰͕̝͚̤̥̙̐̇̑͗̒e͍͔͎͈͔ͥ̉̔̅́̈l̠̪̜͓̲ͧ̍̈́͛v̻̾ͤe͗̃ͥ̐̊ͬp̔͒ͪ
Staff member
Yeah I think the only mistake was manually reimporting the repo, which means GitHub doesn't actually know what what you have is a fork, even though it essentially is.
 
Top