Bug Mafia flips "floristFriarAvailable" to 'true' then back to 'false' when logging in under Standard restrictions

Irrat

Member
I'm in standard and mafia is flipping the floristFriarAvailable preference on and off when I login, I believe because it hasn't loaded my path restrictions at the first invocation, then because it has loaded my path restrictions later, it flips it back to false.

Code:
<snip>
[20:41:50] Initializing session for irrat...
[20:41:50] Loading character status...
[20:41:51] Preference floristFriarAvailable changed from false to true
<snip>
[20:41:52] Refreshing session data...
[20:41:52] Synchronizing moon data...
[20:41:53] Retrieving character data...
[20:41:53] Seeing what's still unrestricted today...
[20:41:54] Done checking allowed items.
[20:41:54] Preference floristFriarAvailable changed from true to false
<snip>

I'm unsure of the intended behavior here unfortunately for mafia internals. My best impression for a lazy fix is probably something like a KoLmafia.isRefreshing() check. Retiring checkFloristAvailable could be an idea too, as it's just acting as a pointless and mildly confusing alias now.

We can also probably remove floristFriarChecked as that preference serves no purpose nowadays. Nothing in mafia appears to read it other than a junit test, and it's a relic of the old florist code.
And Order of the Green Thumb Order Form is now properly tracked under standard restrictions, so the "usable" check can probably use that instead for consistency?
 
Back
Top