Bug - Fixed Bad Image Names

Bale

Bale

Minion
Several items have the wrong image names, presumably because the kolwiki was used as a source. Warning: The image names on the KoLwiki are sometimes chosen for reasons other than mirroring the game. On the wiki they sometimes already have an image by that name so they rename it to avoid conflict.


[table="class: tborder"][tr][th]item or effect[/th][th]KoLmafia and wiki error[/th][th]correct image name[/th][/tr]
[tr][td]note from Clancy[/td][td]document_thumb.gif[/td][td]document.gif[/td][/tr]
[tr][td]gnomish tennis elbow[/td][td]elbow2.gif[/td][td]elbow.gif[/td][/tr]
[tr][td]Bootyliciousness (effect)[/td][td]chest2.gif‎[/td][td]chest.gif[/td][/tr]
[tr][td]Elemental Mastery (effect)[/td][td]elements small.gif‎[/td][td]elements.gif[/td][/tr]
[/table]
 
Last edited:
I see you spotted an error that I missed: Bootyliciousness. I'll add that to my initial post, just for completeness.
 
Someone should fix "checkitems" and "checkeffects" to check these, since they look up the actual item/effect descriptions. We were not storing the image for items, at least, when those commands were written.
 
I wrote a parseImage command in DebugDatabase, but then I realized that one already existed and simply wasn't being used by checkItem or checkEffect :(

Is this something like what you're asking for, Veracity?
 

Attachments

Looks like I expected. Thanks!

Now somebody should install it, run "checkitems" and "checkeffects" and check it all in. :)
 
That was most of it. I also had to change ITEM_DATA_PATTERN to actually include the image name in the parsed text, that's 11383.

Now to actually run the commands. Edit: And see that something needs fixing with image checking in effects, or that lots of images are wrong but it needs to be more descriptive.
 
Last edited:
lostcalpolydude said:
I also had to change ITEM_DATA_PATTERN to actually include the image name in the parsed text
Click to expand...
Actually, you didn't. rawText is the complete description, text is trimmed description. Match in rawText, not text.

Revision 11384 has code tweaks and all the images fixed.
 
Last edited:
That's roughly the fix I was looking at, except I had to change the output for an incorrect image for effects to figure it out.

For some reason, anything above effect 347 is matching against 347 for me, giving 2 incorrect lines for all 700 or so effects above that. Obviously that isn't happening for you, since you updated those effects just fine. I wonder what's causing that issue, but obviously it isn't related to this bug report.
 
You must log in or register to reply here.
Back
Top