Search results

  1. I

    Feature Expand on item_drops_array($monster) or add new function

    The function item_drops_array(monster) currently works as described here: https://wiki.kolmafia.us/index.php?title=Item_drops_array We can expand it, and probably should in some manner, because it misses a lot of the nuance that this sheet covers pretty well...
  2. I

    Bug How should KoLMafia consider Eternity Codpiece slots for 'have_equipped' and 'equipped_amount'

    So here's a puzzle. You are wearing BCZ in a codpiece slot. Currently kolmafia does not make a distinction between the codpiece being equipped or not, when considering the codpiece gems. It's all equipped according to mafia. So, have_equipped, equipped_amount and conditional skills that rely on...
  3. I

    Bug Error when trying to call BitmapModifierCollection for modifiers - Thread race?

    Got an error while maximizing, and it appears to have occurred while my charpane was refreshing. I suspect the charpane refreshing is also to blame for mafia reporting the wrong location when I adventure somewhere. I'm running a fork, but I don't think the fork is especially relevant here. The...
  4. I

    Bug - Fixed Changes to URL handling in KoL broke KoLmafia

    Use uBlock + Firefox?
  5. I

    Feature - Implemented Identify combats from NCs

    Might be a visit URL thing sorry
  6. I

    Feature - Implemented Identify combats from NCs

    Can't you just call fight follows choice function, to check if you are about to encounter a fight. Then add a pref or session storage that flags it. Or at least that's how I do it.
  7. I

    Bug Mafia flips "floristFriarAvailable" to 'true' then back to 'false' when logging in under Standard restrictions

    I'm in standard and mafia is flipping the floristFriarAvailable preference on and off when I login, I believe because it hasn't loaded my path restrictions at the first invocation, then because it has loaded my path restrictions later, it flips it back to false. <snip> [20:41:50] Initializing...
  8. I

    Feature Reduce the amount of I/O wear and tear from writing preferences

    I don't blame at all for not wanting to deal with it, reconciliation is a pain and no one wanted to play with prefs in the first place. It only became a thing due to issues with failed saves, then my complaints about io usage. I went in a slightly different direction regardless, for the atomic...
  9. I

    Feature - Implemented Exposing maximizer failures to scripts when maximizing without a boolean return

    Alright, so what I'm looking at is adding _state which works the same way as _spec Which has stuffed into it Result a boolean modifier, simply if maximizer failed or not Failure Reason A ; seperated list of reasons for the maximizer failure. Combos Considered A numeric count of how many combos...
  10. I

    Bug - Fixed 29151 NPE from multiple scripts

    Duplicate of this, https://kolmafia.us/threads/29151-error-on-modifier-maximizer-npe.32729/ Apparently fixed in newer builds.
  11. I

    Bug - Fixed Heartstone middle letter uses 'lastEncounter', which is not updated on monodent 'talk to some fish'.

    I'm not sure what the expected invocation is, but heartstone_middle_letter() does not understand when a monster is replaced. In this situation, I fought a Dusken Raider Ghost which gives the letter I. I then spoke to some fish which gives no letter. Indeed, I do not have the skill available...
  12. I

    Feature Reduce the amount of I/O wear and tear from writing preferences

    Anyone have any thoughts about this before I mark the pr as ready?
  13. I

    Feature - Implemented Exposing maximizer failures to scripts when maximizing without a boolean return

    Currently when you run maximize via some method that doesn't return a boolean, the script cannot tell if the maximize failed or not. I'd personally prefer not to call two maximizes, when I should only need to call one. Especially because you can, with the below method, limit the scope the...
  14. I

    Feature - Implemented Enable item modes on modifier maximizer

    What's the actual maximizer string you're calling? I thought maximize -shirt adv means it will not modify your shirt mode. Or maximize +equip Jurassic Parka (spikolodon mode) +adv will always have your parka in spike mode. It sounds like you're saying you didn't do any of these, and the bug is...
  15. I

    Feature Reduce the amount of I/O wear and tear from writing preferences

    Yep, the largest remaining IO writes were because some files I had, grew larger than I anticipated. Which is a bit ironic given that they're only written to for about 5 minutes a day. So anyways, has anyone else crunched their own numbers for writes from mafia? I do find it a bit interesting...
  16. I

    Feature Reduce the amount of I/O wear and tear from writing preferences

    So io says about 1.64gb written. 5.91gb written to disk as per smartctl. Although come to think of it, I had been doing some builds over that period, which would explain why it's still higher IO than normal. As for mafia itself still having somewhat high io, no idea. But it's clearly shrunk...
  17. I

    Feature Reduce the amount of I/O wear and tear from writing preferences

    As a small update, been working on this PR; https://github.com/kolmafia/kolmafia/pull/3567 The approach I'm currently taking in it is writing preference changes as an encoded key=value\n. Encoded using the existing encoding setup. Each change is appended to a irrat_pref.journal, supporting...
  18. I

    Feature Reduce the amount of I/O wear and tear from writing preferences

    Monitoring with csysdig, or sudo csysdig -d 10000 and changing view + sort by, there's one file that always topped the results with a refresh time of 10 seconds. irrat_prefs.txt About 3-4mb on average per 10s based over a ten minute sample. Sometimes it dropped below 1mb, and sometimes it went...
  19. I

    Feature Reduce the amount of I/O wear and tear from writing preferences

    I believe I had tested against linux stats, not smartctl. I'll check those numbers later today after my day has run, can compare the smartctl then. I had forgotten to compare it originally, and the final numbers upset me enough that I ended up deleting the script I used to test. I hated the...
  20. I

    Feature Reduce the amount of I/O wear and tear from writing preferences

    Yeah I'm not really sure about periodic saving either. Its really not great in comparison. I'm not sure if you meant kolmafia backups or private backups. I don't think there's much reason to be doing kolmafia backups as a log file is never being rewritten, only appended. We don't have to modify...
Back
Top