Feature - Implemented Enable item modes on modifier maximizer

F

Fart Scauce

New member
Basically just recognizing modes as it's own item like
maximize("combat, equip Jurassic Parka (spikolodon mode)",false)
or equip($item[Jurassic Parka (spikolodon mode))
or cli_execute("maximize combat, equip Jurassic Parka (spikolodon mode)").
Mostly just having the function in the maximizer, but enabling regular equip would be pretty cool too.
 
Last edited by a moderator:
Yeah, modes aren't items, so $item[Jurassic Parka (spikolodon mode)] isn't a thing.

I guess the way to do it would be equip(item, string) and equip(slot, item, string).
 
It would be nice if we could do this in the actual maximizer. For whatever reason, mafia wants to keep switching to a mode I never use if I'm wearing the parka and don't have a shirt that would give whatever I'm asking for. Mostly when I don't have a +adventures shirt, as there's also no parka mode that gives adventures. The maximizer suggests switching parka modes, for +0 adventures.
 
VladYvhuce said:
It would be nice if we could do this in the actual maximizer. For whatever reason, mafia wants to keep switching to a mode I never use if I'm wearing the parka and don't have a shirt that would give whatever I'm asking for. Mostly when I don't have a +adventures shirt, as there's also no parka mode that gives adventures. The maximizer suggests switching parka modes, for +0 adventures.
Click to expand...
Maybe I'm misunderstanding, but this should work in the maximizer just fine. It sounds like it is changing your parka mode because the result would be better for the built-in tiebreaker. You can disable tiebreaker with -tie.
 
VeeArr said:
Maybe I'm misunderstanding, but this should work in the maximizer just fine. It sounds like it is changing your parka mode because the result would be better for the built-in tiebreaker. You can disable tiebreaker with -tie.
Click to expand...
Nope. -tie is used and it still suggests changing modes.
 
VladYvhuce said:
Nope. -tie is used and it still suggests changing modes.
Click to expand...
What's the actual maximizer string you're calling? I thought maximize -shirt adv means it will not modify your shirt mode. Or maximize +equip Jurassic Parka (spikolodon mode) +adv will always have your parka in spike mode.

It sounds like you're saying you didn't do any of these, and the bug is that switching modes did not change the final score at all, so it shouldn't have been considered? So you used maximize advs -tie and it modified your parka for no gain. Which would be a bug, but, I'm unsure if this is what you're talking about. I also don't believe it's new, just not thought about given people can exclude the slot.

Excluding the slot not preventing the mode from being switched, was a bug, and should have been fixed. It just sounds like you're either talking about some other scenario, or saying that maximizer shouldn't change a mode, despite no restrictions, because the final score didn't change.
 
Irrat said:
So you used maximize advs -tie and it modified your parka for no gain. Which would be a bug, but, I'm unsure if this is what you're talking about. I also don't believe it's new, just not thought about given people can exclude the slot.
Click to expand...

Yea, it is this, I believe.

github.com

Fix maximizer recommending mode swaps when no score is achievable by VeeArrKoL · Pull Request #3571 · kolmafia/kolmafia

Currently, there's a narrow case where if a modeable is already equipped, and there is no equipment available to get the score of the corresponding slot above zero, the maximizer result will re...
github.com github.com
 
Irrat said:
What's the actual maximizer string you're calling? I thought maximize -shirt adv means it will not modify your shirt mode. Or maximize +equip Jurassic Parka (spikolodon mode) +adv will always have your parka in spike mode.

It sounds like you're saying you didn't do any of these, and the bug is that switching modes did not change the final score at all, so it shouldn't have been considered? So you used maximize advs -tie and it modified your parka for no gain. Which would be a bug, but, I'm unsure if this is what you're talking about. I also don't believe it's new, just not thought about given people can exclude the slot.

Excluding the slot not preventing the mode from being switched, was a bug, and should have been fixed. It just sounds like you're either talking about some other scenario, or saying that maximizer shouldn't change a mode, despite no restrictions, because the final score didn't change.
Click to expand...
Not using strings. Just using the maximizer tab. I'm not experienced with doing the typed out strings stuff. This pic shows the setup used, but not results, because I'm in the aftercore of a casual run. It'll just suggest a +adv shirt that I do have access to. It only happens when I'm early in a run and don't have a +adventures shirt pulled or bought from the 2002 Mr Store Catalog IOTM.
 

Attachments

  • maximizer1.png
    maximizer1.png
    59.2 KB · Views: 3
You must log in or register to reply here.
Back
Top