Bug - Fixed take_storage() returns true even when it fails in hardcore

[Winterbay]

If you try to use take_storage in Hardcore it fails, as expected, stating that I have 0 pulls and 0 automatic pulls left after which it returns true:

> ash take_storage(1, to_item("meleegra"))

Pulling items from storage...
0 pulls remaining,0 budgeted for automatic use.
Returned: true

I would expect it to return false under that circumstance.

This is with r10220.

 

[slyz]

We have the following in StorageCommand.java:

if ( KoLCharacter.inBadMoon() && !KoLCharacter.canInteract() )
{
	KoLmafia.updateDisplay(
		KoLConstants.ERROR_STATE, "Hagnk's Storage is not available in Bad Moon until you free King Ralph." );
	return;
}

but nothing for Hardcore.

EDIT: that must be because you can still get free pulls from Hagnks in Hardcore.

 

[Winterbay]

That could be it yes. In the meantime while we potentially work on this: Is there a way for a script to determine how many pulls I have left? I can't seem to find a property that stores that number, nor the budgeted number for automatic pulling. Is there no such property?

Or should one perhaps encapsulate ones call to take_storage in an available_amount-call?

 

[slyz]

You can use the pulls_remaining() ASH function.

 

[Winterbay]

Ahh, perfect. That'll do nicely.

 

[heeheehee]

We have the following in StorageCommand.java:

if ( KoLCharacter.inBadMoon() && !KoLCharacter.canInteract() )
{
	KoLmafia.updateDisplay(
		KoLConstants.ERROR_STATE, "Hagnk's Storage is not available in Bad Moon until you free King Ralph." );
	return;
}

but nothing for Hardcore.

EDIT: that must be because you can still get free pulls from Hagnks in Hardcore.

Uh. You can also get free pulls from Hagnk in BM. He's just located in a slightly different location. (I may be mistaken; it's been years since I've last done a BM run)

 

[Theraze]

Fairly sure you can't, in the same way that HP skills are unavailable during BM runs...

 

[Bale]

Actually, I believe that hee3 is correct. You can get Free Pulls from Hangks. I know it is quite possible to retrieve one's VIP Key in Bad Moon. You can't use it, but you can retrieve it.

 

[Theraze]

Ah... the subtle difference between can and can make use of.

 

[lostcalpolydude]

Fixed in 11982. You can now use take_storage() for free pull items too.