Feature - Implemented Show name of reconstituted crow

[Bale]

Remember when you added the feature to display the name of the Reassembled Blackbird in the CLI when the black market map was used (in the CLI or relay browser)?

Yeah, Good times. I liked that. Could we please have the same feature for the Reconstituted Crow?

 

[Veracity]

I'll have to look up what I did for that. I THOUGHT I copied all the Blackbird code to the Crow - and I made a point of naming my Crow this time, for exactly that reason.

I'll be there again in a day or two...

 

[Winterbay]

Looking in my session log this does not appear to have happened but I am almost certain I saw the name of my crow in the CLI when I did the quest last time. I may be completely misremembering though, I tend to do that quite often...

 

[Veracity]

Looking in my session log this does not appear to have happened but I am almost certain I saw the name of my crow in the CLI when I did the quest last time. I may be completely misremembering though, I tend to do that quite often...

What are you expecting to see in your session log?

Here is a session log from April with a blackbird:

Combine 1 broken wings + 1 sunken eyes
You acquire an item: reassembled blackbird

use 1 reassembled blackbird

familiar Reassembled Blackbird (16 lbs)

use 1 black market map

familiar Slimeling (31 lbs)

And here is a session log from my first beecore run:

Combine 1 busted wings + 1 bird brain
You acquire an item: reconstituted crow
Crafting used 1 each of bird brain and busted wings

use 1 reconstituted crow

familiar Reconstituted Crow (11 lbs)

use 1 black market map
You lose 181 hit points

familiar Coffee Pixie (29 lbs)

I see no familiar names in the session log. The name, if previously set, should show up in the gCLI. It fetches the name using the following pattern:

	private static final Pattern FAMILIAR_NAME_PATTERN =
		Pattern.compile( "You decide to name (?:.*?) <b>(.*?)</b>" );

... which is, as far as I know, what you get whenever you grow a familiar that you previously had named. I.e., any familiar in Bad Moon, and the Blackbird or Crow.

 

[Winterbay]

I keep forgetting that the session log is not an exact copy of the CLI-output. That said sicne I got my crow before I got my map I grew it and renamed it before using the map and so am quite certain that the CLI printed the name of the crow.

 

[Bale]

Just for the record, it was not listed in my CLI. I was looking. In retrospect I should have copy/pasted it here. I simply assumed that since I didn't see it, Veracity hadn't done the work yet, so it would be obvious to her. My bad.

 

[Veracity]

Well...it doesn't look like the name I gave to my crow last time was remembered this time. But KoLmafia did pick up the name from the request.

Here is my CLI output when I used the map in the Relay Browser:

[535] Black Forest
Encounter: A Man in Black
You acquire an item: black market map
Verifying ingredients for reconstituted crow (1)...
Creating reconstituted crow (1)...
You acquire an item: reconstituted crow
Successfully created reconstituted crow (1)
Using 1 reconstituted crow...
Finished using 1 reconstituted crow.
Putting Jiggly Grrl the Coffee Pixie back into terrarium...
Taking Grog the Reconstituted Crow out of terrarium...
You lose 214 hit points
Taking Jiggly Grrl the Coffee Pixie out of terrarium...
Requests complete.

And here is what the response to the request to grow it said:

<p>You decide to name him <b>Grog</b>.

 

[Veracity]

Another test: here is what my gCLI says when I clicked the "use map" in the Relay Browser:

Verifying ingredients for reconstituted crow (1)...
Creating 1 meat paste...
You acquire an item: meat paste
You lose 10 Meat
Successfully created meat paste (1)
Creating reconstituted crow (1)...
You acquire an item: reconstituted crow
Successfully created reconstituted crow (1)
Using 1 reconstituted crow...
Finished using 1 reconstituted crow.
Putting Jiggly Grrl the Coffee Pixie back into terrarium...
Taking Gorg the Reconstituted Crow out of terrarium...
You lose 237 hit points
Taking Jiggly Grrl the Coffee Pixie out of terrarium...
Requests complete.

You will notice that it says "Taking Gorg the Reconstituted Crow out of terrarium". My debug log says "You decide to name him <b>Gorg</b>", so we successfully picked up the name, just as with the blackbird.

Interesting enough, I gave my crow a different name before using him last time, but KoL did not remember it. That would be a KoL bug: it remembers the name for a blackbird, but, apparently they did not copy that code to the crow. I'll submit a bug report.

In the mean time, THIS request is fulfilled. Without a change in KoLmafia code.

 

[Bale]

 

[Winterbay]

Yeah I noticed that as well. And I gave my crow a funny name and all