Bug - Not A Bug Numeric modifier always returns integer value

Sigh. Generalize much?

KoLmafia "calculates" based on what the modifier says. Orange Crusher says this:

Code:
Orange Crusher	Muscle: [ceil(min(T,50)/2)], Experience (Muscle): [ceil(min(T,50)/10)]
As you can see, it uses the "T" variable - turns remaining of an effect - in the expression and then explicitly applies "ceil" to it.

Based on that expression, I see no evidence that it "calculates the numeric modifier based on having 1 turn of the effect".
But yes, it "performs a ceiling to the nearest integer".

That is an issue with those particular modifier expressions, not a general issue with "Numeric modifier always returns integer value".

If you did not intend to generalize, perhaps you could have said "Orange Crusher modifiers always return integer value"?
 
P.S. The Wiki, which we KNOW is always correct ;) says the following:

"X is the number of turns of the effect remaining, capped at 50. All fractions are rounded up".

Given that, looks to me like our expressions are exactly correct.
 
Back
Top