Bug - Not A Bug KoLmafia's a bit confused about familiar weight - r12392

gCLI stuff when logging in:

Loading character status...
Adjusting familiar weight by 10 pounds
Retrieving character data...
Refreshing closet...
Examining consumables in closet...
Adjusting familiar weight by -5 pounds

After opening the relay browser, this gets printed to the gCLI:
Adjusting familiar weight by 5 pounds

What's going on? My Gelatinous Cubeling is 30 lbs... with its gear and Sympathy. The initial 10 lbs adjustment makes sense because KoLmafia just realized that I have those two things. The subsequent -5 and +5 corrections, though, don't.
 
It gets a familiar weight from api.php - which may just be the base weight. When it looks at the charpane, it can change its mind.

It'd be nice to track this down - but the right "fix" just might be to remove the "familiar weight adjustment" messages. :)
 
KoLmafia initializes your familiar based on what api.php says its current experience is and then adjusts it from what api.php says about its current weight and "well fed" status. It does that at login before the char sheet has even been read, so it doesn't know your passive skills. Therefore, the weight can get adjusted again after the charsheet is read. The net result is that the familiar's weight gets adjusted at multiple places along the way until it settles into the "correct" value.

One of those places decided to print an informational message if it adjusted the weight. Apparently, that is confusing (just like the "KoLmafia thinks it is round 3 but KoL thinks it is round 2" messages in fights) and (at least one) users think it is a sign of a bug.

It is not. Revision 12421 removes the confusing message.
 
Followup: if, in fact, KoLmafia ends up in a state where the familiar weight is incorrect, that would be a bug. You imply that that might have been the case with your comments about "refreshing closet" and "opening relay browser" and lost suggested/requested that you do "modtrace familiar weight".

That was four days ago and there has been no followup. If you are able to reproduce a real bug - the green pane says the familiar weight is X but it changes when you open the Relay Browser say - and come back with the requested modtrace, I'll revisit this.
 
Followup: if, in fact, KoLmafia ends up in a state where the familiar weight is incorrect, that would be a bug.
I've seen situations where KoLmafia was constantly raising and lowering familiar weight, but that was caused by confusion over what item was equipped and that problem has been solved as far as I can tell.
 
A-ha!

> modtrace familiar weight

sourceFamiliar WeightHidden Familiar WeightFamiliar Weight CapFamiliar Weight Percentamphibian sympathy+5.00=*5.0

Well, that pasted weird, but you get the idea... KoLmafia doesn't seem to realize that the pile of dungeon junk my familiar has equipped gives +5.0 lbs to a Gelatinous Cubeling.
This then leads to KoLmafia constantly flipping back and forth between 25 lbs and 30 lbs every adventure.
 
Back
Top