Calling all KoLmafia developers: request for comments

[Veracity]

Since I know that not all the KoLmafia devs pay much attention to the dev forum (boo! hiss! ), I'd like to invite them all to look at and comment on a Proposal I made there for a major refactoring of the code for simplicity, maintainability, correctness, and ease of updating to support new KoL pages.

Thanks.

 

[holatuwol]

Is 10793 along the lines of what you were aiming to do?

 

[Veracity]

It definitely helps. As I read it, it provides a way to register pages that we support, if and when they are called, without having to pre-build a registry of those pages. Interesting. I'll need to study and understand it some more. Thanks.

 

[roippi]

I have read the thread. I can appreciate the general thrust of it - adding new Request classes is tricky, and we should fix that.

To comment further I'll need to go over what you (and now hola) have written and take a look at the source. I've never added a request myself, so I don't have an intuitive feel for the difficulties therein.