Bug - Cannot Reproduce batching put_shop() commands fails after 11th (post #7)
- Thread starter Bale
- Start date
I can't find a way to break it either.
Bale
Minion
After I had the problem I quit KoLmafia and then restarted it from scratch just to make sure that it wasn't a weird fluke. When it was still broke I downloaded an older revision to see if that worked (and it did) so I knew it was not my system or java installation.
I cannot replicate the error anymore. I'm just flabbergasted at that fact since I ensured easy replication before bothering to make the bug report. All that is left is to mark this bug as "Cannot Reproduce" since I also can't do so.
I cannot replicate the error anymore. I'm just flabbergasted at that fact since I ensured easy replication before bothering to make the bug report. All that is left is to mark this bug as "Cannot Reproduce" since I also can't do so.
Bale
Minion
I believe I found the actual problem I should have been reporting in the first case. I reproduced it. I have changed the thread title to reflect the actual problem.
Using batch_open() and batch_close() around a sequence of put_shop() commands does not send items to the store after the 11th. Successive items remain in inventory although mafia believes them to have been gone. Refreshing inventory reveals their presence.
Using batch_open() and batch_close() around a sequence of put_shop() commands does not send items to the store after the 11th. Successive items remain in inventory although mafia believes them to have been gone. Refreshing inventory reveals their presence.
Considering that there were no changes to anything called by mallsell or put_shop() in revision 11432, I found this puzzling. I downloaded revision 11431's jar file and did some tests.
---
Using KoLmafia v15.4 r11431:
Session log:
I had the DEBUG log going. I saw two requests - one with 11 items and one with 1 item - and I saw KoL's response to each request telling me that it had transferred stuff to the store.
That worked exactly as expected; it split the 12 items into a 11 item request and a 1 item request.
---
Using KoLmafia v15.4 r11438:
Session log:
I had the DEBUG log going. I saw two requests - one with 11 items and one with 1 item - and I saw KoL's response to each request telling me that it had transferred stuff to the store.
This also worked perfectly.
---
I see no bug. Can you give a specific example of a request with 12 or more items that failed to transfer correctly? Perhaps a session log, showing what it thought it was doing?
Thanks.
---
Using KoLmafia v15.4 r11431:
Session log:
I had the DEBUG log going. I saw two requests - one with 11 items and one with 1 item - and I saw KoL's response to each request telling me that it had transferred stuff to the store.
That worked exactly as expected; it split the 12 items into a 11 item request and a 1 item request.
---
Using KoLmafia v15.4 r11438:
Session log:
I had the DEBUG log going. I saw two requests - one with 11 items and one with 1 item - and I saw KoL's response to each request telling me that it had transferred stuff to the store.
This also worked perfectly.
---
I see no bug. Can you give a specific example of a request with 12 or more items that failed to transfer correctly? Perhaps a session log, showing what it thought it was doing?
Thanks.
Bale
Minion
Thank you for being patient with me, but I'm bouncing this bug back to unreproducible status. It worked badly yesterday, but there was no problem today. Here is my session log from yesterday. OCD produced this output: (The stuff with the "> " was OCD's output to the CLI as you'd obviously deduce.)
Notice that the mallsell was done in a single server hit of 20 items, not two separate hits as in your example. After I used "inv refresh" it successfully finished off the remaining 9 items...
That was yesterday. Today it works perfectly:
I cannot figure out what I did differently. Since the today I was not using an older build I suspect it was the same sort of quirk that made the old build work properly for me so I truly doubt it was the fault of some error in r11432 and Veracity is correct about that fact. If it happens to me again and I can figure out why, I will post about it again.
Notice that the mallsell was done in a single server hit of 20 items, not two separate hits as in your example. After I used "inv refresh" it successfully finished off the remaining 9 items...
That was yesterday. Today it works perfectly:
I cannot figure out what I did differently. Since the today I was not using an older build I suspect it was the same sort of quirk that made the old build work properly for me so I truly doubt it was the fault of some error in r11432 and Veracity is correct about that fact. If it happens to me again and I can figure out why, I will post about it again.