Search results

My somewhat hacky workaround without fully understanding why CoinmasterData.token is null is to add null checks in isHP() and isMP(). (And for completeness, the other similar methods that dereference a string without checking if it's null first). diff --git...

Ah, I see fewyn and soolar both reported variants on this in https://kolmafia.us/threads/shop-php-support.30296/#post-176321

Looks like this was introduced in r28347 -- doesn't reproduce in r28346.

As far as I can tell, this started happening in the past ~day. Minimal reproducer: ash sell_price($coinmaster[the dedigitizer], $item[cyburger]) Stack trace that I got from my script that was crashing: class java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because...

I can see the entire private repository because I am part of the KoLmafia organization. I cannot push to the repository, or fork it. It is not publicly viewable.

Might be a matter of deleting the toolchain { ... } stanza which makes more sense if we're raising the compiler floor but isn't necessary if we're sticking to an old version.

Exactly -- that's an authentication issue. Often, for security reasons it's preferable to return Not Found instead of, say, Unauthorized so you don't leak side channel information (in this case: whether a specifically-named repository exists)...

Apparently this is a long-standing issue with Github Desktop -- see https://github.com/desktop/desktop/issues/3870 Just run the following commands: $ git update-index --chmod=+x gradlew $ git commit -m "Update file permissions for gradlew"

Yes, I saw that. As I mentioned, it's a file permissions error -- the Gradle wrapper doesn't have the executable bit set.

(I don't have access to fork the repo or to push to a new branch, so no PRs from me for the time being. I did confirm that the "Permission denied" issue is a simple file permissions issue, though.)

`chmod +x`? Failing that, if you actually have Gradle, you can just run `$ gradle wrapper`.

Given the first phase requirement, I feel like it might be easier to have Multitool (or launcher, or whatever) be in a separate repository under the KoLmafia umbrella project so we can simply check whether the git revision at HEAD matches. That also has the benefit of not polluting the main...

IIRC, there were two contributing factors back in the day: More strongly held opinions about not spoiling limited-time content Concerns about contributing disproportionately to Crimbo-time server load. In recent years, we have gotten the go-ahead from KoL that they're now appropriately...

One downside I see is that we have much more frequent updates than most commercial products, and we unfortunately require users to download a new revision to get the latest changes. Bundling the subset of the JVM that we use increases the download size by around 3x (compare the .dmg size to the...

I don't think there have been discussions of the specific schedule for the next upgrade, so much as discussions about pain points from the last upgrade and how we can avoid them next time. Actually, the next LTS is Java 25, which isn't coming out until late September. I'd be quite surprised if...

Correct. What we could do is add an extra transition stage where we require a new version in code, before actually updating the build version. So something like: One month before we cut over to the new version, start displaying a warning. One week before we cut over to the new version, detect...

That sure sounds like it might arise from my having dropped the TLS 1.2 bit that matt.chugg added. I've uploaded a new .zip with that line added back, but if that doesn't work, I strongly recommend using one of the other community-provided autoupdaters (e.g...

This is not a correct interpretation of either the current or the desired behavior. The maximizer may want to change a slot even if it specifically does not change the score when equipping an outfit which overall will provide a bonus (attributed to some other slot), or to satisfy some condition...

"will" is the operative word, but it's not entirely obvious when. It'll definitely be fixed when we adopt Java 25 after September, and there is a clear desire to backport this fix to Java 21, but the PR has not yet landed.

IMO, doesn't really seem reasonable as a primary motivator if turns between sausage goblin encounters scales as encounters^3 -- even with a million server hits per day (~12/s), that's only like 60 goblins (based on quick calculations using the wiki formula), compared to getting your first 6 in...