Search results

Seems to have been fixed based on spending one adventure :-)

The test above is in https://github.com/kolmafia/kolmafia/pull/2471 and it passes after the Mutex fix. I am still trying to apply lessons learned from the current thread to other tests in 2471 but if anyone wants to review it that would be fine.

OK. I think the thing that was different from what I expected was that (in some sense) the test was "change, or not, acc1". I have seen cases (not necessarily in tests) where the maximizer does change the slot of an accessory even though the score is not effected, so I would tend to write a...

Thank you. What I am missing then is how something(?) decides that "equip acc1" is not the same as as recommending something for ACCESSORY1. Is there a (KoLmafia) semantic that I am misunderstanding that says emitting a command to equip something does not imply that the Maximizer recommended it?

I added it to https://github.com/kolmafia/kolmafia/pull/2471/files# in hopes that my non-failing maximizer tests might get some more eyeballs. :-) The line assertThat(getBoosts(), not(hasItem(recommendsSlot(Slot.ACCESSORY1)))); generated an error Expected: not a collection containing slot...

I can't look myself at the moment but I think there is either a KoL or a KolMafia checkbox (or preference) which allows equipment to be taken from other familiars. What you describe is expected behavior for one state.

Tests that use the resetting client require infrastructure that I just have not convinced myself I understand enough to create. Since the resetting client was created to address a problem that is, or will be fixed, in Java 21 I have been toying with ripping it out. But if GOAWAY is still a...

I assume no longer comes up means you don't see the mafia GUI. You might try running from a command window. mafia detects some errors on startup but they are never logged except to the screen. So opening a window and running from it will display any start up errors. How do you start mafia...

To the extent that my opinion is solicited and informed I vote for this. Single source of truth is almost always the better implementation. I also admit my antipathy towards static because it is one more thing that might possibly leak across tests.

Well it happened today with CannonFire40's butt which is what OnlyFax offered up for someone else's butt :-) I guess maybe I need to find some time to get the debugger out...

Tried to write a failing test to replicate this. Test doesn't fail. Added it to https://github.com/kolmafia/kolmafia/pull/2471 because if someone can help me figure out why my test doesn't replicate the situation it may help me elsewhere and may point to an area in the Maximizer to be...

I have seen the following in my session log several times. Fighting the copy shows a fight with Irrat's butt, as expected, so it is likely that this is just a parsing error. "You receive a photocopied spooky vampire from the fax machine." gets the monster from the preference photocopyMonster...

From my session log. Happened on every encounter that was not a choice.

A couple of years ago GitHub said they were deprecating support for accessing GitHub repos via SVN. About a year ago they just stopped supporting the feature. The ScriptManager entry for Briefcase includes so I would expect Script Manager will do the right thing. My guess is that the SVN...

Autoascend is not the best tool for meat farming. If you are trying to do a run and not run out of meat I have had the best results with not allowing it to restore MP or HP. That said, I still have to do some things manually. If you are meat farming Veracity's Meat Farming does well and won't...

Created New Content thread and moved post there.

There hasn't been too much need for this since the (other) devs are on top of things but I created the thread (and moved a post) so things will be easier to track.

See https://github.com/kolmafia/kolmafia/pull/2523, primarily the last two tests in the file which are driven by function and not a coverage report. I tried to write a test for setting _faxDataChanged using another test (wiki plurals?) as an example. The example injected an http response. My...

@gausie gets the "blame" for modifying that line on 09/16/2023 but I have not dug deep enough to determine whether that was when the misspelling was introduced or whether a previous misspelling was perpetuated.

Darn. The "withResponse" test helpers don't work (for me) when the base code uses a resetting connection. It would be easier for me to just deprecate the resetting connection.