Search results

  1. H

    Multitool - An implementation and feature discussion.

    I believe it dates back to the days of point releases (which we differentiated from the daily builds via "version" vs "revision"). If there was a newer point release than what you were running, Mafia would create a popup recommending that you update. As I'm sure you recall, some segment of our...
  2. H

    New Content Spring Challenge Path: Z is for Zootomist

    Mafia currently thinks your mainstat is muscle. My guess is that KoL is treating your mainstat as the max of the three, similar to Plumber or Grey Goo, but we need different special handling for determining your level in this path.
  3. H

    Feature shop.php support

    The error that I ran into (and which I assume fewyn ran into) was in a script that essentially invoked sell_price($item[cyburger].seller, $item[cyburger]). sells_item unfortunately does not help here, although I think you're spot on with your observation of coinmasters with multiple costs.
  4. H

    Multitool - An implementation and feature discussion.

    I'm inclined to agree, although maybe for slightly different reasons. One, I think JSON is overkill for what we need. Two, I would prefer to keep our external dependencies to a minimum. log4j in particular burned the entire industry quite badly a few years back, so I'm starting from a point of...
  5. H

    Bug - Fixed Checking sell_price of cyburger results in a NPE

    Thanks @Ryo_Sangnoir for r28355 (adapting my patch from #4), which should at least stop the NPEs until we have time to investigate further what the desired behavior should be.
  6. H

    Bug - Fixed Checking sell_price of cyburger results in a NPE

    My somewhat hacky workaround without fully understanding why CoinmasterData.token is null is to add null checks in isHP() and isMP(). (And for completeness, the other similar methods that dereference a string without checking if it's null first). diff --git...
  7. H

    Bug - Fixed Checking sell_price of cyburger results in a NPE

    Ah, I see fewyn and soolar both reported variants on this in https://kolmafia.us/threads/shop-php-support.30296/#post-176321
  8. H

    Bug - Fixed Checking sell_price of cyburger results in a NPE

    Looks like this was introduced in r28347 -- doesn't reproduce in r28346.
  9. H

    Bug - Fixed Checking sell_price of cyburger results in a NPE

    As far as I can tell, this started happening in the past ~day. Minimal reproducer: ash sell_price($coinmaster[the dedigitizer], $item[cyburger]) Stack trace that I got from my script that was crashing: class java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because...
  10. H

    Multitool - An implementation and feature discussion.

    I can see the entire private repository because I am part of the KoLmafia organization. I cannot push to the repository, or fork it. It is not publicly viewable.
  11. H

    Multitool - An implementation and feature discussion.

    Might be a matter of deleting the toolchain { ... } stanza which makes more sense if we're raising the compiler floor but isn't necessary if we're sticking to an old version.
  12. H

    Multitool - An implementation and feature discussion.

    Exactly -- that's an authentication issue. Often, for security reasons it's preferable to return Not Found instead of, say, Unauthorized so you don't leak side channel information (in this case: whether a specifically-named repository exists)...
  13. H

    Multitool - An implementation and feature discussion.

    Apparently this is a long-standing issue with Github Desktop -- see https://github.com/desktop/desktop/issues/3870 Just run the following commands: $ git update-index --chmod=+x gradlew $ git commit -m "Update file permissions for gradlew"
  14. H

    Multitool - An implementation and feature discussion.

    Yes, I saw that. As I mentioned, it's a file permissions error -- the Gradle wrapper doesn't have the executable bit set.
  15. H

    Multitool - An implementation and feature discussion.

    (I don't have access to fork the repo or to push to a new branch, so no PRs from me for the time being. I did confirm that the "Permission denied" issue is a simple file permissions issue, though.)
  16. H

    Multitool - An implementation and feature discussion.

    `chmod +x`? Failing that, if you actually have Gradle, you can just run `$ gradle wrapper`.
  17. H

    Multitool - An implementation and feature discussion.

    Given the first phase requirement, I feel like it might be easier to have Multitool (or launcher, or whatever) be in a separate repository under the KoLmafia umbrella project so we can simply check whether the git revision at HEAD matches. That also has the benefit of not polluting the main...
  18. H

    Feature - Implemented Add a "Pending change in required Java version" nag message.

    IIRC, there were two contributing factors back in the day: More strongly held opinions about not spoiling limited-time content Concerns about contributing disproportionately to Crimbo-time server load. In recent years, we have gotten the go-ahead from KoL that they're now appropriately...
  19. H

    Feature - Implemented Add a "Pending change in required Java version" nag message.

    One downside I see is that we have much more frequent updates than most commercial products, and we unfortunately require users to download a new revision to get the latest changes. Bundling the subset of the JVM that we use increases the download size by around 3x (compare the .dmg size to the...
  20. H

    Feature - Implemented Add a "Pending change in required Java version" nag message.

    I don't think there have been discussions of the specific schedule for the next upgrade, so much as discussions about pain points from the last upgrade and how we can avoid them next time. Actually, the next LTS is Java 25, which isn't coming out until late September. I'd be quite surprised if...
Back
Top