Search results

  1. phreddrickk

    Feature - Rejected numeric_modifier (or some new function) to look at the enchantments of bjorn/crown familiars

    Right now mafia (and the maximizer) has information about the enchantments that the Buddy Bjorn and Crown of Thrones give when a familiar is bjornified or enthroned, respectively. This information gets used in the maximizer, but doesn't appear to be exposed through any API that scripters can...
  2. phreddrickk

    Feature - Implemented Add _lastCombatLost Preference

    Running from combats does not register as a win (as you didn't win), but would similarly not register as a loss (because you also don't trigger <!--LOSELOSELOSE-->). You could combine _lastCombatWon with a check for beaten up or low hp, but the Personal Massager (and possibly other items) will...
  3. phreddrickk

    New Content Tiny Stillsuit

    `drink stillsuit distillate` appears to not give an overdrunk warning when called in the CLI. I have a `drinksweat` alias that I errantly called this morning and ended up overdrunk, which I mention in case somehow being an alias is causing the bypass. I'll put in a PR once I can figure out the...
  4. phreddrickk

    New Content - Implemented unoccupied sheep suit

    I believe the metal meteoroid (choice adventure 1264) and the burning newspaper (choice adventure 1277) are implemented as foldables rather than coinmasters, and they seem very mechanically similar to this.
  5. phreddrickk

    Bug - Fixed divide by zero error when consuming spleen item

    That's calling this overload of maximumUses, which passes ConsumptionType.NONE into the full implementation of the function. That does bypass the area of code I highlighted earlier, which only applies to ConsumptionType.SPLEEN, but we still end up using item name to look up organ size here. If...
  6. phreddrickk

    Bug - Fixed divide by zero error when consuming spleen item

    The issue isn't with the spleen proxy record, but with dailyusesleft, and it does appear to exist with ash: > ash $item[extrovermectin].dailyusesleft Changing "extrovermectin" to "Extrovermectin&trade;" would get rid of this message. (char 7 to char 21) Returned: 2147483647 What I assume is...
  7. phreddrickk

    Bug - Fixed divide by zero error when consuming spleen item

    I just ran into this, and think I have it narrowed down: https://github.com/kolmafia/kolmafia/blob/3d57e177a80915b96def5026e4309f088e3f74b7/src/net/sourceforge/kolmafia/request/UseItemRequest.java#L445-L447 we're using the item name to get the spleenHit, and both Extrovermectin and Breathitin...
  8. phreddrickk

    New Content deed to Oliver's Place

    This is now mostly implemented (and has been for a while now). There is a mild snaggle in current implementation: right now, doing a turn-taking combat in Oliver's Place doesn't automatically set the preference to 3. This was a deliberate choice on my part; using a back-up in a fight will cause...
  9. phreddrickk

    Bug Scratch 'n' Sniff Weapon is not considered by maximizer if it has a negative bonus

    For what it's worth, my understanding is that it'll only increase execution time in situations where a negative bonus is assigned, and I think people will only assign a negative bonus if they actively don't want to -equip the item. So I'd be inclined to change this. If it would increase...
  10. phreddrickk

    Bug Mafia appears not to be tracking _spaceJellyfishDrops when I autoattack with a macro (r26881)

    Just managed to replicate it (sort of). I didn't get it to trigger on a combat where I obtained a stench jelly, but here's a debug log where the second jellyfish message doesn't appear in the session log: My combat macro looked like this: Which is unfortunately a little hard to read. When I...
  11. phreddrickk

    Bug Mafia appears not to be tracking _spaceJellyfishDrops when I autoattack with a macro (r26881)

    I'm still encountering this periodically (I know it's not just bad RNG because mafia is incorrectly tracking the amount of stench jelly in my inventory), but, like you, when I actively tried to replicate this behavior I have trouble with it. I'll try to get some more precise details as to when...
  12. phreddrickk

    New Content - Implemented November IOTM - Cookbookbat

    It also seems like one recipe drops per day, so we'll want a _property to track that as well
  13. phreddrickk

    New Content - Implemented Miniature Crystal Ball tracking post January 10th 2022 changes

    For what it's worth, I don't see much wrong with option 3. Unless this is a meaningful divergence from current behavior (which I don't think it is, but I've been wrong before), someone trying to parse that text directly into a monster will error from time to time, but it won't be "for no fault...
  14. phreddrickk

    Bug Mafia appears not to be tracking _spaceJellyfishDrops when I autoattack with a macro (r26881)

    Here's a combat where I submitted a combat macro to the fight, rather than using an autoattack: And here's one where I did the same thing but didn't come up with a jelly: One thing to note here: I'm getting a failure message--"it doesn't seem like any jelly is forthcoming." Here's a combat...
  15. phreddrickk

    Bug Spring Loaded Bumper tracking broken when used as freerun on unbanishable monster

    I know there were some proposals a while ago to have a `lastAsdonBumperTurn` pref (I think people had a better name than that). Is that the best solution for this, or does someone have a better idea?
  16. phreddrickk

    Bug - Fixed june cleaver preferences not updating

    It's compiled from typescript: function juneCleave(): void { if (get("_juneCleaverFightsLeft") <= 0) { equip($slot`weapon`, $item`June cleaver`); skipJuneCleaverChoices(); withProperty("recoveryScript", "", () => { adventureMacro($location`Noob Cave`, Macro.abort())...
  17. phreddrickk

    New Content October IOTM - Autumn-aton

    Fixed in 26828
  18. phreddrickk

    New Content October IOTM - Autumn-aton

    I'm headed back to the haunted kitchen for drop mechanic spading, but if you let me know which ones you're missing I can set my script to hit up some specific zones when I'm overdrunk.
Back
Top