Search results

Well, I don't know the script, but I would like to get the pieces, so I'm happy to look at it with you. Need to finish my current run and get into aftercore.

Hmm. I would be concerned that that change might introduce churn to existing scripts that, sometime in the last decade, had used the existing behavior in some way and would now break. It might be ok to create a new command like clear_location().

It looks like it's been that way since at least 2013: public static void setNextAdventure(final KoLAdventure adventure) { if (adventure == null) { return; }

Well, this is a script for a feature that hasn't changed much in 10-15 years. It's pretty static and since you can call both BALLS steps and Consult scripts from a CCS, it doesn't really seem like a candidate for improvement. Anything you might suggest, someone would likely say "meh. Use a...

hmm. Did you have items added or removed from your inventory while maximizing?

glad it's working!

So, I can't find it in in that debug log, but that's a huge log. There are definitely team members who are much better with log parsing than I am. I see ClanRumpusRequest, which is the first step of Breakfast for me... Here's my recommendation for how to debug this. Test with the latest build...

Not our bug, but useful information. If there's a better category for this, we can move this... https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/ If you see the error below (in your terminal or IDE of choice), the blog post above recommends the following two commands to fix it...

It would be possible to write a JSON_to_map function for ASH, but it's not a perfect fit. 1: JSON doesn't require each object to have the same format, so parsing needs to be careful. 2: JSON doesn't enforce any structure on the keys, and map will overwrite a key-value pair if the key is a...

I started writing something up and googled for a piece I needed and found this fine guide: https://codingbeautydev.com/blog/javascript-convert-json-to-map/ here's the meat of it: const json = '{"user1":"John","user2":"Kate","user3":"Peter"}'; const map = new...

well, I went to merge it, it required an update and invalidated the approval. Also, it seems to be stuck waiting for tests that it says aren't being run. Can I get some help getting this over the finish line?

Wiki updated: https://wiki.kolmafia.us/index.php/Data_Types

I have two concerns with my change. 1: anyone who was relying on the wrong behavior. 2: longs greater the JavaScripts MAX_SAFE_INTEGER Number one I don’t feel like should be a problem. Number two could bite JS, but we’ve moved the problem from 32 bits+ to 53 bits+.

Changed to return DataTypes.makeIntValue(((Number) object).longValue()); Now it returns a Long to JS. > ash now_to_int(); Returned: 1677680054630 > js nowToInt(); Returned: 1677680061644

@fronobulax , my new understanding is that valueConverter.fromJava() (Java code on our side) is coercing all numbers to integers, instead of longs.

The original symptom was that the javascript function nowToInt() was returning a negative number. We determined that it was the 32 bit 2s complement representation of the 41 bit epoch time in milliseconds. I tried a fix and nobody liked it, including me. I'd like input on the right way to...

I think I ate one during 2CRS. It was not optimal, but it was possible. Aside: I have 82. If you want one, hmu. Apparently I collect them, accidentally. That part of the maximizer is a giant list of sequential IF statements: // You must have the pill keeper if...

I'm still somewhat skeptical. That feature is basically unusable by me as it is, because there's far too much that gets stuffed into it. I supposed advanced unusable is no worse than basic unusable, but it's not like you can't find food/drink/spleen on the food/drink spleen tab already. What...

R27217

I was thinking about this recently. But I could possibly distend my stomach, take a spleen pill, over drink, etc. Figuring out the best approach is not easy. I'm loathe to add another preference, but maybe "disable eat/drink/spleen by default if full" would work?