Search results

I tried jamming in some recalculateAdjustments while looking at https://kolmafia.us/threads/mafia-setting-timesrested-to-0-on-login.29268/, but I never managed to make it work. If it works in the place you've got it, that's good to go, I think.

A side issue is that, after modtrace recalculates your adjustments, the sidepane still shows the previous value -- it needs a KoLCharacter.updateStatus() call to update.

I posted some investigation in https://kolmafia.us/threads/missing-1-drunk-capacity-starting-with-27601.29257/ -- there's a race condition to do with the passive skill cache. I don't know whether this is the root cause, but it might be.

Okay, so somebody else reported this (from after freeing the king), so I did some investigation and found the following, copied here for ease of reference: yeah, I can see a race `Modifiers.availablePassiveSkillModifiersByVariable` is cleared by `resetModifiers` which is called by...

This is the same way that the Baby Mutant Rattlesnake works, yes? So the existing Mafia modifier should be fine.

This is the inverse of https://kolmafia.us/threads/mafia-setting-timesrested-to-0-on-login.29268/, but I still haven't figured out how to get it to work correctly.

Okay, so it looks like whether free rests are available is updated for Chateau or Campground rests, but not Campaway rests. I can look into adding that.

The compact side pane bug is different (though it looks similar) -- I think the fix for that one just wants a "KoLCharacter.updateStatus()" call after the session is initialized. This one is about modifiers being computed incorrectly at first login.

I ran through some tests with ASH: have_skill and item_amount return the right values, but inebriety_limit returns the wrong one -- until the first recalculateAdjustments (e.g. "modtrace liver capacity" will do one -- though that also adds debug behaviour). I tried adding some...

You could: click the "refresh" button run "refresh all" run "modtrace liver capacity" open the relay browser and any of those should fix it. It needs to run recalculateAdjustments, and to be aware of your skills. Again, I'm surprised that you're able to adventure (presumably gaining stats or...

r27610, thanks for the report.

Some other comments on https://kolmafia.us/threads/sidepane-no-longer-shows-inebriety-limit-until-refresh.29265/, which is the same issue. Specifically, this is because you have free rests available on logon, but Mafia calculates how many free rests you have incorrectly, so it sets the number...

It looks like it doesn't properly set the skills while initially setting session data (in refreshSessionData in KoLmafia.java). However, this doesn't make any sense to me -- because at the top of the function it calls GenericRequest request = new CharSheetRequest()...

Probably something to do with the order things run in. The same problem occurs with the daily deeds for free rests. I guess something needs to prompt it to update after the first recalculateAdjustments of the session. Or we extract the static initializer from modifiers and move it to the main...

Fixed as of r27608. Thanks for the report!

27601 switched to reading liver from modifiers instead of a custom method, but Hollow Leg is a passive skill so I don't understand why this isn't working.

They couldn't be copied during Crimbo, but they were marked as copiable after Crimbo. They can't be fought using Genie wishes because they have an "executeonwin" function. You can Rain Man them if you have factoids, and they're faxable.

I hit this while passing a function with an invalid return -- e.g. "[1].map(x => x.key)" would output [undefined], but trying to print this on the GCLI crashes. > js null Returned: null > js undefined Returned: org.mozilla.javascript.Undefined@7fadecaf > js [null] Unexpected error...

Nice find! It would need to be added to src/data/monsters.txt I'll PFC the rate tomorrow.

Try: ash numeric_modifier("Zone:Shadow Rift", $modifier[Item Drop]) You could also set_location($location[none]); to avoid the zone modifier entirely.