Search results

Okay, so I was mistaken -- we don't refresh KoL state, only internal modifier state. So in src/net/sourceforge/kolmafia/maximizer/Maximizer.java, try changing // ensure current modifiers are up-to-date KoLCharacter.recalculateAdjustments(); to if (KoLCharacter.inQuantum()) {...

It uses the seal tooth when it wants to go to the underworld, or when it wants to repeat the combat (e.g. to flyer multiple times). As this is intended it's not toggleable.

Hi all, Much like we started requiring Java 17 two years ago, we're now considering requiring Java 21 (for example, so that we can use the simd-json library for faster JSON parsing, which may help people with extremely large inventories, like me). If you're using it, you don't need to make any...

Yes, the stillsuit uses them: that's how we're getting the other tags. Pokefam also uses them.

Exactly that (anything in modifiers.txt using "famattr"), and that's actually incorrect (unless CDM has changed it since): the warbear foil hat uses a hardcoded list of familiars instead of the robot tag. I would be in favour of making pokefam a type instead of a tag, like underwater already is.

Are you using Bjorn or Crown, or is this just familiar equipment? We refresh before we start maximizing, so I'm surprised it can get your current familiar wrong, which is what appears to be happening.

All of these have a "Tag" different to their "Name". I don't know what this means (apart from behaving exactly as you've seen: "name" is what is passed to $modifier[], "tag" is what appears in the data files). Sporadic meat / item drop, Familiar experience, percentage stat experiences, familiar...

r28102

I expect script authors are reading the commit history / release notes for new features (new item support, new quest support, new skills, new commands, new functions). I only post major or breaking changes in Announcements. I don't think this is a major change. I wouldn't have thought to post an...

I did not (or I did, but it cleared from my alerts before I noticed it was there). I do have the preference enabled for mentions; I don't know if it works at all. I do get alerts for when people like my posts or quote them (as you have done in this thread). I feel like most of these questions...

Hi, I also didn't receive an alert for this thread. I don't get alerts for "GitHub changes" more generally: perhaps I disabled them, or perhaps they're disabled for everyone. I asked bean to add a docstring for the json API in the code: I figured that was enough, given the wiki doesn't have...

Suppose we have a script that wants to adventure in the Hero's Field with a particular filterFunc -- adv1($location[Hero's Field], -1, "handle_8bit_combat") Furthermore, suppose we have a pre-adventure script that wants to ensure we have enough +item drop to maximize our points gained in the...

Ah, a heisenbug! This makes it hard to figure out exactly what's going on but given what heeheehee says (there is a skill that offers +1 exp) I figure it's related to the cache somehow. When you had debug off it thought nothing offered exp unless you had nothing in your hands. I thought the...

You can set the property "maximizerFoldables" to false to ignore them by default.

Looking at the modifiers, we can see that the error is when it goes from considering equipping the unbreakable umbrella, to considering nothing. Sometimes nothing counts as -25% item (e.g. 4 -> 5, 25 -> 26), and I assume this is actually unequipping the bucket, given that ML % is 0 consistently...

That makes sense: you've asked for item and exp, and the Candelabra cannot give either of those. As mods.toString() doesn't work (it reads from MODIFIERS which isn't necessarily set), could we print everything that seems relevant: RequestLogger.printLine("Item: " +...

Very good, nice to have that excluded. Below "RequestLogger.printLine(this.equipment.toString());" that you added in MaximizerSpeculation.java, could you add "RequestLogger.printLine(this.mods.toString());"? This should show us the extra mods that exist.

I'm okay with requiring an upgrade. I didn't want to force it because I can't see anything in 21 I really want -- 17 brought records, and I think those were worth it.

Combo 21 is the same as combo 2 and 5, but while those score 999.75, 21 scores 1393.2 As you are comfortable recompiling Mafia, could you add a log in src/net/sourceforge/kolmafia/persistence/ModifierDatabase.java, line 432, to see if it ever sets a familiar on the modifiers object? I added a...

Unusual things which are true for you: you don't have a familiar, and you don't have either a weapon or offhand equipped. If you equip a familiar, can you still reproduce? If you equip a weapon, does it still recommend nothing, or does it recommend an offhand in that case? Can you `modtrace...