Search results

Well, it's very interesting, and I hope I found what I was looking to find. The bad news is my sync fix above didn't solve it. I made a draft PR of just the test in case anyone wants to dig into it. method timeinDoesNotCauseRaceCondition sets an unrelated pref starts a timeinThread starts up...

Does the fact that we have the prefs in memory (until we clear them) make the case atypical? I don't think we read from disk unless we're timing in. That seems like a promising approach. I'd have to read from disk after I wrote to make sure it was persisted and nothing was lost.

Did more research into sync, which is a new area to me. What I learned: Any things that use the same monitor object are mutually exclusive (one of anything that is in a synchronized (lock name) block, regardless of the code block) Synchronized methods and class effectively are like a...

I learned the Kent Beck version: "Make It Work, Make It Right, Make It Fast" The Preferences.saveToFile() method syncronizes with a monitor object named lock, which is not used in any of the other methods of Preferences. Can we reuse the lock across methods, or is it just for one method, which...

This may be something we could test, but I'll have to see if I can write a failing test for it first.

So, my hypothesis is that a write is happening on another thread (possibly a script thread or a relay thread?) while the timein is running, so there's a race condition. I know that at times, I've had scripts wake from sleep and be just fine, but that's the thing about race conditions. If...

That's not a bad extension of this. I'm pretty sure we haven't solved the whole problem (and we couldn't hear; it's just a backup). But we can definitely extend the design to also backup the global prefs. Considering the number of recent anecdotal reports involving scripts and...

I am also unsure what the correct behavior should be, but perhaps a wording change would help. buf.append(" Press 'Yes' if you are satisfied with the current connection."); buf.append(" Press 'No' to log out and back in to try for a better connection."); buf.append(" Press 'Cancel' to...

Is there a way other than editing the prefs to change the threshold or goal value when doing a relog? Either parameters or a Preference page option to set the same things once the character has logged in.

If I use relog until I get the dialog because my ping is too high and then I choose cancel, it allows me to try things in the gCLI and throws errors. I'd like it to go back to the login window like typing logout in the gCLI does.

I'd like to request that "verbose" to be an alias for "true" in the gCLI parameter list. It took me a few moments looking at the help command to figure out that verbose wasn't literally verbose, but the value of a boolean and I needed to use "true" If I have timed out, the first request to...

I may be experimenting with this, but not with my main... The life on those cookies is like 60 seconds, Forgot the [sarcasm] tags again...

@fronobulax , I stepped through the code and the requests return AWSALB cookies. Those cookies are documented in AWS's Sticky sessions for your Application Load Balancer, which is probably how they're doing it. Nobody wants to roll their own ALB if they don't have to. I think the scripters are...

We're getting an AWSALB cookie (and an AWSALBCors cookie). Can we just clear our AWSALB cookies without logging out? If KoL is using the Application Load Balancer the way Amazon expects, that will cause the LB to send us to a potentially different server. That will either work just fine or...

r27371 added join_strings(string[0],string) last month. > ashref join_strings string join_strings( string [0] ) string join_strings( string [0], string ), which matches the function definition on line 8. It's likely that you can comment out lines 8-17 (the join_strings function from the...

if you move your hello world or kolmafia jar to a directory that isn't under Documents, do they work?

Hey Sparklebeast, sorry you're having troubles! My guess is that this is an environment issue. I have four recommendations to try first: Try running cmd.exe as administrator, then executing your command. get a newer JAR file. This will test if something just went wrong with the file you...

So we already have some of this kind of information available using the dump command, but it goes to the CLI. I have two ideas (which might be complementary and) that might be useful here. if keyword dump (or 2 dump?) included in the GUI, show the shortlist as an ...or list. possibly make...

So, would a tiebreaker option of "- some score points for 'not on hand'" help?