Search results

This is the function I'm seeing. Is this a function we should adopt? It sounds like the answer is no. buffer copyBuffer(buffer buf) { buffer result; result.append(buf); return result; }

Looking into the Bastille code, which has (and uses) their own to_buffer, I also see a defined function buffer copyBuffer(buffer), which seems like it's the equivalent, except it takes a buffer instead of a string. It's not used in Bastille, but is in all the same Ezandora-derived scripts and...

It would make things more flexible if script authors could override built_in functions, but I'm wondering what the implications are of letting a script override a built in, especially if the script gets included in another script. What if they had differing definitions? While it won't be the...

One thing I just noticed, and I'm not sure if there's an ideal way to address it, is that if I timein by pressing the "Load in Web Browser" toolbar button and the connection is too slow, the dialog box is opened in the app that is now behind my web browser. The app will switch to a browser...

would it help to move from Synchronized to java.util.concurrent.locks.ReadWriteLock? They'd still be locked against writes, but they'd allow multiple reads.

That's been a hard one to build good tests for. We worked mostly with Preference.increment(), because it exercised read and write and depended on the before-state. But perhaps we need to move on from synchronized() to tryLock() , or better ReadLock()/WriteLock(). (or other lock methods if...

Hmm. I like either running a script or an alias, but would it be useful to have escapes in there?

would also recommend adding the dump parameter to the maximizer string to get more information about what is being considered.

The docs are here: https://wiki.kolmafia.us/index.php/Daily_Deeds You might want to see if this advice applies. It's for the $TEXT type, but it might solve your problem. If you want to use a comma in your text, immediately follow the comma with a pipe character so it will not be parsed as...

It's not a bad feature request, so feel free to put it in as a new one.

Pressing the up or down arrow populates the text entry with the prior message or the next one if there is one (after pressing the up arrow, for instance. In the gCLI, the same phenomena occurs. When you overwrite the text entry, the list of prior messages does not add the current string to...

I did some spot testing and couldn't make it reproduce. I tried a lot of things, including installing and removing scripts while I had that open. the @ckb menu worked really badly if it was on icon menu and we loaded his stuff, but it never told me it was detecting incorrectly or glitched. I...

many fewer messages. https://www.kingdomofloathing.com/awesomemenu.php?pwd&action=toggle From around line 781

Oh, the version on mine is because I'm working from my IDE. That version number is off, but I was testing with your development branch before the PR was approved. Otherwise, I'm working in Preferences.java and PreferencesTest.java, so it shouldn't have any affect on this testing, but if you...

I was also looking for events attached to the elements there, but I think some of it is round-tripping to the PHP server. I'll grab debug as well. Would trace be of any help?

So, I tried the new version. I couldn't break it, but I did see the error message. The fix seems to be working so far for me for this test case (I don't think this is the only path to the problem, though). A few times KoLmafia detected NORMAL when it was FANCY and KoLmafia thought it was...

Well, I have no friends who are still playing, so I don't get gifts. I am probably rare in that respect. Most people give up before I do. I typically view the descriptions in the relay browser by clicking on the icon and viewing the documentation in the browser window it opens. I think that...

Maybe it's not, or not for this discussion. I was trying to suggest that my way of playing wasn't the only way of playing and people who do use the mini-browser might not be as surprised by the method of displaying the message. I also always want the funny/cute messages. For me, the gCLI...

Maybe we could send it to the gCLI. The mini browser isn’t something that’s normally part of my play style.

PR for rollback. I asked you to review. https://github.com/kolmafia/kolmafia/pull/1855