Search results

Hmm, just realized that the "Script Manager" looks to be looking at SVN scripts only, it could probably do with a tune-up of its own tbh. Though that'd be a separate thread. Thoughts on a tuneup being 1. Listing what versioning system it uses 2. Allow scripts installed outside of mafia's...

By now everyone should be aware that Github is removing SVN support, and most github scripts should already be encouraging use of git over svn. https://github.blog/2023-01-20-sunsetting-subversion-support/ However, some people will be lazy and some will still get caught by surprise. I think...

So we have several zones that will force a non-combat, which we could start tracking. I may be missing a few as these are off the top of my head. Black Forest - The NC is a super-likely after 4 fights without a NC The Hidden City - Hidden Apartment & Office Building - They occur after X fights...

Description When an error is thrown by javascript that contains a newline, I sometimes found that despite the script no longer running, I cannot interact with mafia's GUI. The buttons are grayed out as if a script is in use. The issue appears to be here, which simply means that if the output...

I was thinking that breakfast would run normally, it doesn't check the pref.

The hermitage sells 11-leaf clovers, but scripts do not have the ability to tell when a clover has been purchased or not without checking the hermit, or attempting to purchase. I was thinking about adding a tracking of some sort, with two solutions coming to mind. 1. We track how many clovers...

Wondering if it'd be a good idea to have mafia update _locketMonstersFought to include a placeholder monster ID if kol reports all reminisces used, even though mafia didn't know about them. To prevent using an actual monster, and prevent breaking scripts expecting a real monster. We could use...

What I figure is that ItemDatabase saves the display name in decoded form, but ConsumableDatabase saves it in encoded form. It fetched the name from ItemDatabase and tried to use it in ConsumableDatabase. Edit: Looks like I missed Veracity's comment

I wasn't worried about this myself, was just intrigued when someone in discord was confused and I looked into it.

It appears as part of a change, the zones for astral adventures was changed from "Astral" to their own unique names (Bad Trip, Great Trip, Mediocre Trip) The commit the change was made. This means that in the choice panel, it's apparently looking for "Astral" which those locations no longer...

Currently, you can get your clan name, and your clan ID. However mafia does not support a way to switch clans, or retrieve your whitelisted clans. Instead to find this information a script has to fetch and parse a page. This wouldn't be a real issue, but for those scripts that aim to automate...

Oh, that's a thing? Huh. https://github.com/kolmafia/kolmafia/pull/1238

I went with 2, ultimately it should give the majority of support needed. If you have an ambiguous monster, just parse the monster and get the monster manuel name to find out what monster was actually predicted. So if you see `Ninja Snowman (Hilt)` then you know `Ninja Snowman` was predicted...

Fair enough. Removed them and marked the PR as ready

Alright, all tests are added. Beach Bucks and funfunds are no longer tracked as they are reoccurring. The code for the friar trio still exists and should still work if the encounters are fixed. I think the options for what to do about that before the PR can be marked as ready are.. A. Remove...

Replying to this thread instead of making a new one. So I've taken it as a personal offense that crystal ball tracking isn't as reliable as it should be, and made a PR here So the real question is, what should we do with ambiguous monster names? I'm actually referring to specifically these...

Cool. But yeah, turns out funfunds is an occuring adventure. But not sure if beach bucks is the same. Occurs every 50 adventures apparently. Added the other 4 along with their tests.

"hallowienerFunFunds"

I have a PR here which trains hallowiener encounters. So you can tell if you've already gotten the volcoino this ascension, or the beachbucks, or the NC in the bat cave. Etc. Now, because I'm "very smart". I made this PR even though I do not have a Haunted Doghouse. Because I can't generate...

Bumping this instead of creating a new thread. I think for a simpler implementation of this, we could add "stop" command. And a [STOP] button next to the "[REFRESH]" button in the mafia GUI in the side pane. Using either of these will set a preference asking the script to stop "stopRequested"...