Search results

Reverted everything locally, updated to newest revision, applied patch, and yes, there were lines missing. No idea how it happened, I can only assume I misclicked on a checkbox when telling Eclipse to make the patch. Now I know to add one more step to my testing process: After creating patch...

Happy Valentine's Day (almost)! To show my love and appreciation for you guys, here is the formatted LockableListFactory patch number 1. There are more LockablelistModels to convert, but that can be done later (on another holiday perhaps). Quick summary of changes: Major change: Any class that...

Thanks guys! 99% done with formatting, will upload the final patch tomorrow. I also created an eclipse formatting file (whatever it's called), so I should magically have the same whitespace rules as you guys now. Re: smaller patches, I absolutely understand what you mean, however this review...

Just what you always wanted! A LockableListModel patch that actually works! Well, you can update your Crimbo list because I have what you want! So this patch is pretty much the same as the last one, but with a few changes: The very eloquently named FakeLLM class has been deleted. A new utility...

Alrighty, so I finally got started on LockableListModel. I tried using a List in some places and LLM in others, but there are some LLMs in KolConstants that absolutely needed to be LLM when it came to GUI. So I ended up going with a Factory. I also moved some things from KoLConstants to...

FWIW, mafia now runs a little bit on Android: 01-30 17:02:41.939 1232-7002/? I/System.out﹕ KoLmafia v17.2 r16639 01-30 17:02:41.939 1232-7002/? I/System.out﹕ Released on November 28, 2015 01-30 17:02:41.939 1232-7002/? I/System.out﹕ Currently Running on Linux 01-30 17:02:41.940...

Re: LISTENER_, you are correct- it makes more sense. I changed that. Re: whitespace. Crap, I knew I forgot something. I changed that as well! Done! :)

Alrighty! So this is a new patch that works correctly as far as I can tell. Things I'm trying now: Use GUI to train Use cli to train Run a script that adventures and use gui/cli to train while the script is running What I've done in this patch: The listeners I added are now fields of the Frame...

Alrighty, figured it out ahead of schedule! So it was all entirely my fault. The ListenerRegistry keeps a bunch of WeakRefs to all the registered Listeners. The new Listener instances in my patch were only defined within the scope of the FamiliarTrainingFrame constructor, so once that was done...

So.. one year later, yes- there is definitely some bug introduced by cakepatch. I don't believe it is a threading issue though- what I see is that listeners don't get fired after a while. I still don't see a crash, but I will keep investigating and update this thread (next year, probably).

Whoa, I didn't see any issues with the cakepatch, which means I obviously missed something. I'll try out bccascend today and see what's going on! Re: whitepace, noted! I'll make sure that my whitespace matches the project standard. I'm used to different whitespace rules at work, so I guess...

Would it be easier if I just make one huge patch with all the changes I'm supposed to make? I could do that, I'm just afraid that would make reviewing harder, and nobody really wants to look at a 100 line diff. Or should I keep posting small patches every so often?

CakeArenaManager Another patch! In this one I do something different- I register 2 listeners and fire them in CakeArenaManager. This is because CAM needs to append to the ChatBuffer as well as clear it, but update() doesn't tell me which listener is fired (if multiple listeners are...

Wow, that is amazing. If mine ends up working (since the problems I'm having are also GUI related) then it seems that matt.chug's would work as well! Wow. Did I say wow yet? And I hope that Java installer works- it'll be easier than doing the nonsense I'm doing! Good luck!

Oh wow, somebody was trying on iOS? Even with Android using Java it's barely possible (let's see if it works!); I can't even imagine how this would work on iOS. I know there are Java -> Obj C conversion tools, but from what I understand, those tools aren't 100% reliable. Anyway, you weren't...

Alrighty, I have another straightforward review: BuffBotHome and BuffBotFrame. BuffBotHome contained the following code: which as far as I can tell does nothing. In case you're wondering, it is empty. BBH isn't extended by anything so it's not like this is being overridden. Since this created...

I believe you're talking about this ;) I was trying, but RL got in the way like crazy and I stopped- I only got one review in. I'm on leave now and was semi-actively working on it but I was in Nepal during the earthquake, so RL got in the way even more!

Thank you so much! :)

Thanks! And I do hope it does no harm! I ran my local jar and it was working fine, and in theory it should work fine as well, but I really do appreciate you taking some time to verify it!

Hey guys, I don't mean to pressure anyone, but what's the general timeline for getting a patch looked at? I absolutely understand if people are too busy to take a look, but I'd really appreciate an update anyway!