Search results

  1. MCroft

    Bug Null Pointer Exception if maximizing while being fought in pvp or receiving a kmail

    hmm. Did you have items added or removed from your inventory while maximizing?
  2. MCroft

    Breakfast suddenly stopped working.

    glad it's working!
  3. MCroft

    Breakfast suddenly stopped working.

    So, I can't find it in in that debug log, but that's a huge log. There are definitely team members who are much better with log parsing than I am. I see ClanRumpusRequest, which is the first step of Breakfast for me... Here's my recommendation for how to debug this. Test with the latest build...
  4. MCroft

    Feature Builders: GitHub RCA key rotation may cause failures updating your GitHub project(s)

    Not our bug, but useful information. If there's a better category for this, we can move this... https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/ If you see the error below (in your terminal or IDE of choice), the blog post above recommends the following two commands to fix it...
  5. MCroft

    JSON

    It would be possible to write a JSON_to_map function for ASH, but it's not a perfect fit. 1: JSON doesn't require each object to have the same format, so parsing needs to be careful. 2: JSON doesn't enforce any structure on the keys, and map will overwrite a key-value pair if the key is a...
  6. MCroft

    JSON

    I started writing something up and googled for a piece I needed and found this fine guide: https://codingbeautydev.com/blog/javascript-convert-json-to-map/ here's the meat of it: const json = '{"user1":"John","user2":"Kate","user3":"Peter"}'; const map = new...
  7. MCroft

    Bug - Fixed nowToInt() vs. now_to_int()

    well, I went to merge it, it required an update and invalidated the approval. Also, it seems to be stuck waiting for tests that it says aren't being run. Can I get some help getting this over the finish line?
  8. MCroft

    Bug - Fixed nowToInt() vs. now_to_int()

    Wiki updated: https://wiki.kolmafia.us/index.php/Data_Types
  9. MCroft

    Bug - Fixed nowToInt() vs. now_to_int()

    I have two concerns with my change. 1: anyone who was relying on the wrong behavior. 2: longs greater the JavaScripts MAX_SAFE_INTEGER Number one I don’t feel like should be a problem. Number two could bite JS, but we’ve moved the problem from 32 bits+ to 53 bits+.
  10. MCroft

    Bug - Fixed nowToInt() vs. now_to_int()

    Changed to return DataTypes.makeIntValue(((Number) object).longValue()); Now it returns a Long to JS. > ash now_to_int(); Returned: 1677680054630 > js nowToInt(); Returned: 1677680061644
  11. MCroft

    Bug - Fixed nowToInt() vs. now_to_int()

    @fronobulax , my new understanding is that valueConverter.fromJava() (Java code on our side) is coercing all numbers to integers, instead of longs.
  12. MCroft

    Bug - Fixed nowToInt() vs. now_to_int()

    The original symptom was that the javascript function nowToInt() was returning a negative number. We determined that it was the 32 bit 2s complement representation of the 41 bit epoch time in milliseconds. I tried a fix and nobody liked it, including me. I'd like input on the right way to...
  13. MCroft

    Bug Maximizer: if (e.g.) full, effects from food sources get filtered out of the final list, even with "Show all" pref selected

    I think I ate one during 2CRS. It was not optimal, but it was possible. Aside: I have 82. If you want one, hmu. Apparently I collect them, accidentally. That part of the maximizer is a giant list of sequential IF statements: // You must have the pill keeper if...
  14. MCroft

    Bug Maximizer: if (e.g.) full, effects from food sources get filtered out of the final list, even with "Show all" pref selected

    I'm still somewhat skeptical. That feature is basically unusable by me as it is, because there's far too much that gets stuffed into it. I supposed advanced unusable is no worse than basic unusable, but it's not like you can't find food/drink/spleen on the food/drink spleen tab already. What...
  15. MCroft

    Bug Maximizer: if (e.g.) full, effects from food sources get filtered out of the final list, even with "Show all" pref selected

    I was thinking about this recently. But I could possibly distend my stomach, take a spleen pill, over drink, etc. Figuring out the best approach is not easy. I'm loathe to add another preference, but maybe "disable eat/drink/spleen by default if full" would work?
  16. MCroft

    New Content - Implemented calculating familiar weight off by one (due to 2CRS ring)

    parseItemEnchantments does, indeed add up the enchantments. It was easy. I spent more time finding that all the components I needed were there and ripping out my version than coding. I did not store it as a property, because I didn't know that there would be any use for it.
  17. MCroft

    New Content - Implemented calculating familiar weight off by one (due to 2CRS ring)

    First one in a while: https://github.com/kolmafia/kolmafia/pull/1530
  18. MCroft

    New Content - Implemented calculating familiar weight off by one (due to 2CRS ring)

    I've looked at the description that we get back and I'll need to de-duplicate it (+2% meat from monsters and +4% meat from monsters are both there and they stack). I'm just working on wrangling the description's modifiers into a format to send to overrideModifiers(). And then I'm going to try...
  19. MCroft

    New Content - Implemented calculating familiar weight off by one (due to 2CRS ring)

    I thought it would be a bear because there are 170 possible keywords. But that’s just size.
Back
Top