Search results

This patch makes the appropriate changes. I compiled and tested it a bit to make sure it works.

Eating a sausage has no opportunity cost, and restores 999MP. Could it be added to the list of MP recovery items?

Not even if I implement it myself? OK then, I guess I’ll add it to my login script. Sorry about not checking for previous requests. I’m usually better about that, but it must have slipped my mind.

This skill creates an item once per day, just like other skills that are already implemented in the breakfast system. Note that it needs to be cast repeatedly until it succeeds.

I did, with a hardcoded item array. However, I feel that properties of the effects themselves should be part of KoLmafia, as that is precisely the type of information that proxy records are meant to store. Moreover, a hardcoded array will become outdated quickly, and everyone would have to...

If you want a counterexample: “On the Trail” is not decremented. Also, I’m willing to code this myself, if you would accept the resulting patch. I’m not asking you to spend your own time on it beyond that.

Here’s my personal use case: my logout script tries to optimize for PvP as much as possible (without affecting rollover adventures and such). This includes removing buffs that would confer a disadvantage in PvP. I am in the second camp you described, by the way.

I meant that, insofar as is possible, the feature won’t require much support.

First off, this isn’t just about one PvP minigame (not least because it affects two). This affects anyone with active effects who initiates PvP fights. Some effects are quite valuable, and it is useful to know which ones will be decreased through attacks. Right now, that information is not...

It could work if KoLmafia ignored unconditional triggers when deciding whether to swap equipment, but that feels messy.

Upon reflection, I think it’d be impossible. KoLmafia has no way of knowing if unconditional triggers actually need to do something, and that means that it cannot tell if a mood is actually doing anything. And switching equipment back and forth before literally every adventure would hardly be an...

I’m very sorry. I’m rather preoccupied right now, so I didn’t check. Rather than assuming “unrelated” meant “not close to the lines changed”, I should have forgone replying entirely until I had that time. That being said, it isn’t as obvious as you seem to assume. I only know that adjacent...

Patches only contain changes, not the entire file that was changed. So long as the reordering didn’t affect anything near the changed lines, that shouldn’t be an issue.

I saw that, but I’d still rather make that a setting. On a related note, is it possible to configure moods to equip MP-saving gear, then restore the original gear after finishing execution?

I was recently trying to figure out how to equip MP-saving gear when executing my Mood in a way that didn’t entail switching back and forth with every individual skill. I ended up looking at the source code to see if there was a hidden setting or something, and it turned out that such a function...

I’ve changed the patch to account for the fact that you can multi-use magazines.

The only steps that actually have to block are copying the effects before a fight and after. Comparing the two can be done on a different thread, as no functionality is actually impacted by it. I may be used to copy-on-write structures these days, but I’m still fairly confident you could have...

If you feel that particular back-end implementation would be better, then sure. You’re obviously much more familiar with Kolmafia than I am, and the end result would be the same. In fact, I can probably make a patch for that right now.

Why would we have to synchronize the GUI? I know Kolmafia maintains a cache of effects, and it already has to refresh that after each PVP fight. The PVP code is a bit hard to understand, but it seems like you could save a map of effects after executing “beforePVPScript", then check for anything...

While we’re on the subject of the “skill” type, I feel like a lot of those fields should be on “effect” instead. In particular, “song” and “expression”. That may not be worth fixing, as it would be a breaking change, but still.