Search results

Hi all, After getting a little frustrated with how quickly Mafia chews up my laptop battery, I decided to run it through a profiler to see what seems to be generating the most CPU usage. Below are some quick highlights from a first run while running a farming script, and I'd be happy to dive...

I have a PR up at https://github.com/kolmafia/kolmafia/pull/1162 and just need to finish the tests. Bizarrely, the chateau_restbox action works for both free and non-free rests - which action fires depends exactly where you click on the bed/text in the Chateau.

Hi Veracity, Just to double check, did you fork the project first? Since you don't have direct permissions to push to main on that repository, you will have to push to a fork of the project and then file a PR across repositories. That's how contributors to Mafia who don't have commit access...

Looks good to me, thanks!

We should fix the ultimate exception not being caught, but these are currently catchable in JS: > jsq Item.get("sword") Internal exception: Wrapped net.sourceforge.kolmafia.textui.ScriptException: Bad item value: sword (command line#1) at command line:1 Unexpected error, debug log...

This is unfortunately a tricky limitation to work around in the JS-to-Java-to-ASH conversion chain and any fix is going to be a little bit of a hack. I'd recommend using TypeScript to avoid typing issues like this. I will think about how to fix this particular issue.

Here's a fix for the value conversion issue that philmasterplus was seeing, test with js Monster.get(33).phylum === Phylum.get('undead')

Yes, I meant merge them both in sequence.

Can someone merge those two patches?

Thanks for finding that fix. I'll take a look at the value conversion issues you mentioned. A fix to another problem with importing ASH scripts that overload functions:

That is not Mafia's current behavior when loading cli/ash files. If that's an issue we should probably take this to PM

Yeah, it should probably just be "undefined".

Alright, this patch fixes both the sandbox issue and the issue with trying to print require("kolmafia"). I've left the behavior with no input unchanged for now as we should fix the ASH command as well. The sandboxing rule is now that any file in the Mafia directories can be run by the JS...

OK. I'll investigate.

Okay. I'll set up the dev environment on my Windows computer this evening and see if I can come up with a fix. Thanks for flagging this.

Huh, that's odd. Might be a Windows issue specifically since I have been doing all my development on a Mac... If you have time, it would be helpful to see where in the Rhino code that exception is coming from. It's supposed to be restricting execution only to scripts that reside within the...

You may want to coordinate with gausie, who is also working on type definitions here. I have an example of a fully-working TS project with webpack and babel up here: https://github.com/phulin/bean-daily. My plan was to leave the types as global, like JS's built-in types. Gausie also made the...

The previous patch fixes some pretty breaking bugs, so would love to get it merged whenever possible. Here's another (applies only against the previous patch) that moves the standard library onto require("kolmafia") instead of a global. It also fixes some of the interrupt problems.

Fixes some bugs with argument inversion on library functions, and some type conversion issues. It also reworks some of the proxy record code to work in a more consistent way.

And... a patch to make enumerated type equality work correctly.