Search results

  1. phreddrickk

    Bug - Fixed Irregular +/- combat rate modifiers interact poorly with the soft cap

    Just as a note first, I unfortunately don't know exactly how these modifiers interact with the soft cap in the real world. But, A user with this modtrace is getting a 1-turn CS -combat test rather than a 3-turn one. I've looked at (most) other possibilities, and it feels like the most likely...
  2. phreddrickk

    Feature - Implemented get_permed_skills ASH function

    This feature request comes free with a PR! I've been automating my ascensions and gash-hopping process lately, and I'd like to add support to Mafia for the tracking of permed skills. Mafia appears to already track some of this information in KoLConstants.permedSkills, so it feels like this...
  3. phreddrickk

    New Content April 2022 IotM: Unbreakable Umbrella

    Per CannonFire40, it works with scalers, although it won't push them above their cap. I believe someone spaded it working with the slime tube and with -ML, although I'm not absolutely certain about the tube.
  4. phreddrickk

    New Content April 2022 IotM: Unbreakable Umbrella

    Well, I have tried my hand at continuing the rest of the implementation here, basically aping the Saber code at every possible turn. Here is the PR in question.
  5. phreddrickk

    New Content April 2022 IotM: Unbreakable Umbrella

    I think @gausie mentioned having an idea for implementing it without adding a new modifier
  6. phreddrickk

    Bug - Fixed r26329: camelSpit not updating at end of combat

    Thanks for the prompt fix!
  7. phreddrickk

    Bug - Fixed r26329: camelSpit not updating at end of combat

    `prefref logf` shows that logFamiliarActions is set to true. "Nebraska at low weight" is indeed the name of my camel--Nebraska is the only state with a unicameral legislature. I don't see anything that would make status.camel different, and my familiar name hasnt' been changed since yesterday...
  8. phreddrickk

    Bug - Fixed r26329: camelSpit not updating at end of combat

    From the end of a recent combat, in my log After Battle: You hear a loud schlurrrrrk! noise, and turn to see Nebraska at low weight sucking the liquid out of a bottle of Haterade he found somewhere. (3% full) You acquire an item: psychokinetic energy blob (5) You acquire an item: frigid...
  9. phreddrickk

    New Content April 2022 IotM: Unbreakable Umbrella

    Unwraps into unbreakable umbrella can fold into one of six forms by visiting inventory.php?action=useumbrella, and then going through the choice adventure that follows. Form 1 is the Broken version, which gives +25% Monster Level. That's right, +25%. Form 2 is the Forward-oriented version...
  10. phreddrickk

    Bug use() returning incorrect values for Clara's Bell

    According to the wiki, use() should return false for items it fails to use.
  11. phreddrickk

    Bug - Fixed assigning the buddy bjorn a bonus while using -buddy-bjorn results in failure

    I've partially implemented this, but when I ran the full gamut, basically every test that uses recommendedSlotIsEmpty started failing with messages like org.opentest4j.AssertionFailedError: Expected unchanged hat slot, but it was <html><font color=gray>(nothing useful found)</font></html> ==>...
  12. phreddrickk

    Bug - Fixed assigning the buddy bjorn a bonus while using -buddy-bjorn results in failure

    I'm switching over to modFor, but it definitely feels like this is either unintended behavior or I'm misunderstanding what's happening re: recommendedSlotIs.
  13. phreddrickk

    Bug - Fixed assigning the buddy bjorn a bonus while using -buddy-bjorn results in failure

    To continue our conversation from the PR: It looks like the failure isn't coming from maximize, it is in fact coming from the `recommendedSlotIs(EquipmentManager.CONTAINER, "Buddy Bjorn")`. What's weird as hell is that this error persists when I remove the `-buddy-bjorn` from the maximizer string.
  14. phreddrickk

    Bug - Fixed assigning the buddy bjorn a bonus while using -buddy-bjorn results in failure

    Update: I figured it out! The issue lies in the fact that right now we're using a value of FamiliarData.NO_FAMILIAR to communicate two very different ideas: either a carrier-familiar slot that is yet to be assigned a value, or one that has actively been assigned a value of none. I've built a...
  15. phreddrickk

    Bug - Fixed assigning the buddy bjorn a bonus while using -buddy-bjorn results in failure

    Yep, which means that whatever fix we end up drumming up for this will probably(?) obviate item.requiredFlag I do not; if I did, I feel like that would be even weirder. I honestly wasn't sure if this was still part of the scope of the same thread as before, given that that thread started with...
  16. phreddrickk

    Bug - Fixed assigning the buddy bjorn a bonus while using -buddy-bjorn results in failure

    A fix for a related (but not identical) issue was implemented here (thanks, Fronobulax and Midgley). A similar issue persists when dealing with the bonus keyword, instead of the equip keyword. When I maximize with -buddy-bjorn, the bjorn slot empty, and a bonus attached to the bjorn, the...
  17. phreddrickk

    Bug using the -buddy-bjorn maximizer command unequips the buddy bjorn item

    Sorry to necro this, but I wrote a failing test for the weird behavior we're encountering now. I'm not currently making a new thread because all of these feel pretty entangled as issues: https://github.com/kolmafia/kolmafia/pull/662
  18. phreddrickk

    Bug "swim sprints" sometimes fails to update _olympicSwimmingPool

    I'm not able to find rhyme or reason to when this happens for me. It appears to not happen in my CS ascensions, but does appear to happen in my casuals. Both use cliExecute("swim sprints") to swim sprints. Looking through the mafia source code, this could be related to the fact that most of...
  19. phreddrickk

    Bug - Fixed Preference _glitchMonsterFights getting changed to boolean somehow

    I can put in a PR for this in a couple of hours if it hasn't been addressed by then. EDIT: it has!
  20. phreddrickk

    Feature - Implemented Custom combat disable for fully scripted KoLMafia users

    I feel like I'm missing something here. The request here just seems to be "give people a standard empty CCS to reference, so that scripts that use an empty CCS don't bloat up your file." These scripts are already overriding the user's CCS. Plenty of scripts do this, often times setting up a CCS...
Back
Top