Search results

Fix is waiting approval. This doesn't actually do anything so don't worry about it too much :)

Solution is to fix BatBrain. Here is your new line 427-430 matcher rng_matcher = create_matcher("\\{.+?,(.+?),.+?}",""); string deranged(string sane) { rng_matcher.reset(sane); while (rng_matcher.find()) sane = sane.replace_string(rng_matcher.group(0),rng_matcher.group(1));

@Ryo_Sangnoir submitted a PR to fix it (I think!) which has since been merged

Well here are those HTML files at least. I can take a look at the two problematic shops tomorrow

This is really fantastic work from which everyone will benefit. Thank you Veracity. Is there an easily sliced area we can contribute codewise?

I am very pro a launcher being made

I ask that we resolve to have a discussion before implementing "policies" in the development of the project, especially ones gatekeeping contribution. I'm not strictly against this one in particular but I am definitely not convinced. I certainly would not follow it for my own feature PRs, so as...

Had a quick look at this, the choice adventure is run in an infinite loop. Visiting the relay browser triggers the NPE (in the JavascriptRuntime??) somehow but only if you have a relayScript that calls visit_url() in some way, even if that relayScript is ASH. Really weird bug.

Haha just realised it will still probably NPE if you give a null path. I'll wait for the bug report, or when I get around to it - whichever is sooner.

https://github.com/kolmafia/kolmafia/pull/2436

https://github.com/kolmafia/kolmafia/pull/2435

Oh I can fix this.

Not to be rude but I have to say this: it's not a beta feature, it is a totally unsupported implementation detail that I don't have any remote interest in maintaining.

Hmmmmm. I wonder what is going on.

The .dmg is unsigned so it doesn't even work really. I should really fix that...

I didn't point you towards this API and there was no agreement to its ongoing behaviour. The API I previously indicated - the one that lets you query a particular item - still works as expected.

Did you mess with that HTML source at all? Usually it comes through with no linebreaks to the DEBUG file

Just to note: we also need to track the calendar being reset in The Hidden Temple (some debug HTML of this happening would be appreciated!) and the free rests (for which Ryo has a PR currently)

Yep! Thanks https://github.com/kolmafia/kolmafia/pull/2304

If you can attach a debug log of an affected campground.php, I can sort