Search results

  1. roippi

    Bug - Fixed Nullpointer-exception during session initialization

    I've already implemented a locking scheme so that only one (low-level) SVN operation can fire at a time; in this case there is a bit of a race condition with how I coded the show-commit-log function. Should be a one-in-a-million sort of thing but it can happen. I really just need to make the...
  2. roippi

    Bug - Fixed Nullpointer-exception during session initialization

    You managed to fire off two svn update operations at the exact same time. I'll see if there's any way to prevent that, but in the meantime, don't do that.
  3. roippi

    Feature Update the proxy fullness for pizzas when you have Pizza Lover

    Why? The item proxy field is a property of the item. The food manager is giving you a view of what will happen when you eat the item. Asking proxy values to update according to character status seems like an un-feature to me. If I ask for an item's adventure range, I expect the value I get...
  4. roippi

    Feature Pretty names for github SVN

    r13539 Not sure if it will break anything for currently-installed users. If there's a more succinct way of unique-izing the URL, we can do that. I just used everything after github.com.
  5. roippi

    Unable to install scripts through SVN

    Looks like your DB file is locked for writing, for whatever reason. you can try doing svn cleanup but that won't work if your OS still has the file locked. You may need to restart your system. As for what caused it: could be a number of things. Antivirus, external svn client, etc. Hard to...
  6. roippi

    Do I have to stop for semi-rares?

    XY problem
  7. roippi

    Check this out: Vim syntax highlighting

    This is sweet. I think someone posted a .vimrc (or whatever) for ash a long time ago but I recall it needing maintenance. I don't code much .ash but when I do, I use vim, so I appreciate this existing.
  8. roippi

    Bug - Not A Bug Laggy relay browser

    The same place you should start in any reasonably complex debugging operation: a completely vanilla install of mafia.
  9. roippi

    Official script registry - discussion

    mkay, this is what I'm going to be working off of, let me know now if we want to change the spec. It has a superfluous .txt extension because this forum isn't happy with *.json files. For any curious, the way I generated this in python: import json chit = {'name':'CHIT','author':'Bale...
  10. roippi

    Official script registry - discussion

    Right, category is a thing. Probably easiest to make all fields mandatory since that makes the spec straightforward.
  11. roippi

    Official script registry - discussion

    Okay, I'm gradually working on this, and I'm at the point where I really need a solid spec for the registry file. Remotely retrieving it, etc. can wait. I'll post an example JSON-ified file soonish, but here's the bare minimum fields I'm thinking of: script name author(s) short description...
  12. roippi

    Bug - Fixed Excessive calls to api.php & listener firing while refreshing session

    It's also the block responsible for seting KoLMafia.continuationState to CONTINUE. That's all I had in mind when you said "defer", in retrospect it would be clunky. I like the way you implemented this. I feel like this "defer things into a set" motif could be used in other places in mafia to...
  13. roippi

    Bug - Fixed Excessive calls to api.php & listener firing while refreshing session

    Interesting. That's definitely suboptimal. I do like the idea of enqueuing calls to fetch character state, so long as no operations depend on said information being up-to-date. Do we perhaps want to explicitly tie the "undefer" step to RequestThread.closeRequestSequence? (or somewhere...
  14. roippi

    Bug - Fixed property questF01Primordial is not updated at all

    pretty glaring typo in questslog.txt. r13325 Many (most? all?) miscellaneous quests are missing all intermediate steps, which is why they won't update from a questlog hit to anything other than started or finished. If someone wants to do the work and provide an updated questlog.txt, ok.
  15. roippi

    Bale's Relay Overrides

    Isn't that just a hacky way of doing what url_encode() should be doing?
  16. roippi

    Bug property "questG04Nemesis" not updated

    This is one of many quest properties that has not been implemented to live-update. We only guarantee the properties are up to date after a questlog hit. In the case of ascension-relevant quests we try to live-update them.
  17. roippi

    Character Info Toolbox

    that is a message from the svn client, not mafia. Mafia doesn't have a hook to run that command (though it could). Somehow you got svn into a state where it has some locked files. Either use an external svn client to do the cleanup operation, or delete/re-checkout the project. I'm out of the...
  18. roippi

    Feature - Implemented Customizable options in the Maximizer drop-down

    That pref is only meant as a means of serializing data, it was not intended to be interacted with - that's just a detail of how the serialization was implemented. If you want to submit a patch that reworks it, okay :)
  19. roippi

    Feature - Rejected Purchasing from NPCs only

    I believe "acquire" will prefer NPC shops when available rather than comparing NPC and mall and deciding which is cheaper. I recall an old bug report to that end. I also don't necessarily think this is wrong behavior. As for buy_npc: meh. If you are specifically looking to limit your...
  20. roippi

    Feature - Implemented Proposal: maintain lastAdventure and nextAdventure

    Just piping up to say that AdventureSelectPanel should implement PreferenceListener and listen to (I think, if I understand the proposal correctly) nextAdventure. Right now, it looks like we have to both set the preference and update the GUI in separate steps, which is prone to breaking...
Back
Top