Search results

  1. MCroft

    Bug Prevent swing popups from stealing focus

    I think the relay browser coving a window with focus was a concern at one point, @Irrat , can you give specific examples of the dialogs that are popping up? There was some work done earlier this year on the case of the popup that appeared when using the seal tooth, but I think it didn't have...
  2. MCroft

    Bug Mall Purchase GUI "search" fails after timein

    What are your steps to recreate? I've been looking at this and it's acting annoyingly correctly. There is also unexpected behavior around the field related to selection. I can't select all (CMD-A) in the Item to Find field. Is it filtering out keypress. I can copy and paste, and if I...
  3. MCroft

    Bug Mall Purchase GUI "search" fails after timein

    I've absolutely seen the latter. I don't know what to do about it, except maybe not allow searches for every item from the gui.
  4. MCroft

    Bug - Fixed Javascript toJson leaves object keys in underscore_format rather than camelCase

    Per the JSON-defining RFC, order should not matter. This is not to say it never does.
  5. MCroft

    Feature - Implemented Persistent command history / control history size

    That's what I was thinking with the filter option, similar to inv item. To do that, I'd want a specific separate history file (eg Mad_Carew.history.txt, like .zsh_history)
  6. MCroft

    Feature - Implemented Persistent command history / control history size

    tbh, I would be most interested in duplicating the "history" command in bash. "What did I do?" It might be nice if we had the ability to dump the history with an error so we knew what the user did. I might also want to filter it, but not unless it was stored to a separate history file (like...
  7. MCroft

    Feature Collect Untradable Pulls

    Hey finally saw this in practice. It's a good add!
  8. MCroft

    Bug - Fixed The option to show both the Combat Action Bar and the old form at the same time causes problems for automating combat

    So the button is getting the wrong value. The code is working right to use it, but the static decorator is thinking the the currentRound is 0 (and thus we need that link to go to main.php, not the fight.php with a macro). That's because FightRequest.updateRoundData() thinks we're no long in...
  9. MCroft

    Bug - Fixed The option to show both the Combat Action Bar and the old form at the same time causes problems for automating combat

    So, some screenshots with a better description. 1: First I validated that the "Scripts" button on the CAB was inserted by KoLmafia (it is. It is not in vanilla KoL, where it would not make sense) 2: Then I opened the Options and went to Combat Options. I enabled Combat Options Bar and fought...
  10. MCroft

    Bug - Fixed The option to show both the Combat Action Bar and the old form at the same time causes problems for automating combat

    Yeah, it’s on my plate, but I like to document bugs in case someone else finds them or finds them after I fix things. I will make a better description, and see what I learn.
  11. MCroft

    Bug - Fixed The option to show both the Combat Action Bar and the old form at the same time causes problems for automating combat

    So, seeing this setting, I turned it on, hoping it would be convenient, because sometimes I do pull up the old form. It would be, but it's causing the automation of combat to fail. If I press the script button on the CAB or if I use the "Begin" button the the Swing GUI, it returns "You...
  12. MCroft

    Bug - Fixed Javascript toJson leaves object keys in underscore_format rather than camelCase

    Looks like it's in Garbo's outfit code. scripts/garbage-collector/garbo.js: var outfit3 = Outfit.from(spec, new Error("Failed to construct outfit from spec ".concat((0, import_kolmafia62.toJson)(spec), "!"))); scripts/garbage-collector/garbo.js: var outfit3 = Outfit.from(spec, new...
  13. MCroft

    Feature Collect Untradable Pulls

    Well, It starts to seem like daily deeds, restores, or breakfast (which have very different interfaces). I have actually never broken my Hippy Stone and never want to do PvP; putting it on a page for me to skim past would not help me. So some way that we could let a user configure what was on...
  14. MCroft

    Feature Collect Untradable Pulls

    Meat is obtainable, though I might be able to sell something and get 500 meat. I might even prefer to do that than miss my chance to send Gausie some toast. Adventures are harder to generate, as are recipes. I'm not sure when to draw the line between can't do X, could do X, and could do X...
  15. MCroft

    Bug adding August Scepter skill Fresh Breath! to mood causes NPE

    NPE prevents Adventure and Skills pane from loading. diff of mad_carew_moods.txt showing reduced test case. < [ testlist ] < lose_effect fresh breath => cast 1 aug. 6th: fresh breath day! < _aug6Cast is true, so I should have no more casts. I haven't yet determined if it's a data error or...
  16. MCroft

    buffer to_buffer(string)

    This is the function I'm seeing. Is this a function we should adopt? It sounds like the answer is no. buffer copyBuffer(buffer buf) { buffer result; result.append(buf); return result; }
  17. MCroft

    buffer to_buffer(string)

    Looking into the Bastille code, which has (and uses) their own to_buffer, I also see a defined function buffer copyBuffer(buffer), which seems like it's the equivalent, except it takes a buffer instead of a string. It's not used in Bastille, but is in all the same Ezandora-derived scripts and...
  18. MCroft

    buffer to_buffer(string)

    It would make things more flexible if script authors could override built_in functions, but I'm wondering what the implications are of letting a script override a built in, especially if the script gets included in another script. What if they had differing definitions? While it won't be the...
  19. MCroft

    Feature - Implemented Relogging to improve ping

    One thing I just noticed, and I'm not sure if there's an ideal way to address it, is that if I timein by pressing the "Load in Web Browser" toolbar button and the connection is too slow, the dialog box is opened in the app that is now behind my web browser. The app will switch to a browser...
Back
Top