Search results

  1. MCroft

    Bug You are too drunk to continue

    fixed a typo in choiceControl.java. PR in place. It was looking for Relaxin Balm and the actual value is Relaxin balm.
  2. MCroft

    Bug You are too drunk to continue

    This is my WereProf in Prof mode: > modtrace liver type source Liver Capacity Skill Liver of Steel +5.00 = +5.00 Path WereProfessor +9.00 = +14.00
  3. MCroft

    Bug You are too drunk to continue

    You can only visit the research bench as a Professor. It is unavailable when you are a Sexy Savage Beast. I definitely ran into that when I first ran the latest WereProfessor build and started as a Beast. It cleared up when I became a Prof. I don't know if there's a way to tell what...
  4. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    It looks like the test is calling the 2 parameter version of maximize. It looks like Autoscend is calling the 4 param version . void equipMaximizedGear() { finalizeMaximize(); maximize(get_property("auto_maximize_current"), 2500, 0, false); // below code is to help diagnose, debug...
  5. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    I bring it up because I think I see it in my log (from comment above) candy cane sword cane scores 774, more than "none" or "Turtle totem". It says "ccsc, saucepan", in the shortest shortlist, then it picks turtle totem, then it equips nothing. IT doesn't try to equip nothing, but nothing...
  6. MCroft

    Bug - Not A Bug r27822 Unwanted password dialog box pops up with Chrome + KoLmafia

    It looks like it's all over the google forums and assorted product forums. People are advising to turn it off on per-site basis, but I can't find instructions or steps to do that. It looks like it's a chrome issue, but if you can find a difference in the HTML between vanilla where it's not...
  7. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    Do we have any test cases where this is the case? Every example I've seen has a higher number value for some weapon other than [None] and a message that it is equipping something and not doing so. Which is to say that I agree that there could be such circumstances, but I have not seen them...
  8. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    Tests of code that is not covered are a good thing in themselves. There are tests we can add to maxmizer's effective test class, such as... public void useKnifeWhenMuscleIsHighWithTrickyKnifework() { ... } @Test public void useKnifeWhenMoxieIsHighWithTrickyKnifework(){ ... } However, we might...
  9. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    I've suggested privately to Loathers that they abandon the Effective keyword as radioactive and instead write their own "if" statement related to moxie > muscle and having Tricky Knifework. I'm working on an enhancement instead to add Tricky Knifework handling to the melee keyword. I'm not yet...
  10. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    I see your point. I would say that I consider it a bug because the outcome of using it is both unexpected and the worst possible result. We warn people if they are going to take 1-3 hp of damage from using a seal tooth, and this is a much worse outcome. However, I am open to considering it a...
  11. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    Alternatively, perhaps we can change knives from melee to ranged if the character has Tricky Knifework and not have to have a special keyword for at all.
  12. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    I am unsatisfied with this result, which is OK, but I will at least explain my reasoning and you may not agree. It makes the plain wording of the keyword not work. 1: I have asked for effective weaponry. 2: I have found effective weaponry 3: I have tried and failed to equip a non-effective...
  13. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    Can you go over the cases where "there is no solution for the requested modifiers" is the right answer but doesn't fail? That seems like it is a fail state, or should be. The reason being that the unarmed condition is a melee attack, so if unarmed, the moxie class is not meeting effective. If...
  14. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    I also wondered what the keyword was supposed to do. The +effective keyword came out while I was on hiatus from Kol in 2015 and it was not vital to any scenario I cared about when I came back, although I had Tricky Knifework (or did soon enough). The original ask was to provide a way to...
  15. MCroft

    SVN updates since January 2024

    At one point we talked about making git support into a package manager, which would've included a "this is where the script starts" metadata object, but there just wasn't enough enthusiasm (or at least not enough skilled enthusiasm) to make it happen. The good news is that Live/Ascend/Repeat...
  16. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    I'm one of those. What I see is that it tells me it is wielding the Turtle Totem and then doesn't. Which suggests to me that it isn't a failure to determine the correct item but a failure to actually equip it. [ERROR] It looks like the maximizer didn't equip any weapons for you. Lets dump...
  17. MCroft

    Running Mafia on Windows

    In the olden times, this was a big problem with Windows 7 and Java 8 over Java 6. That all might be dead IT knowledge, but there are a bunch of interrelated registry entries: https://superuser.com/questions/1194758/unable-to-run-jar-files-by-double-clicking-them-on-windows-7 I hope this is all...
  18. MCroft

    Running Mafia on Windows

    I am not a Windows user, so I have very little to say, except that I do have a little bit... Thank you for collating all the information we have that may help someone. Java 17 or better is required. Java 17 is recommended, as it is a Long Term Support version that is "17 or better". Recently...
  19. MCroft

    "Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0."

    So, the short answer for me was ./gradlew clean && ./gradlew runShadow or just running it from my IDE. The full error tells you how to set it up "properly", which is to set the relationship between cleanest and runShadow. Look at "What went wrong" below... We probably shouldn't, since there...
  20. MCroft

    Shall it be closed?

    ages ago we thought about ReadWriteLock or ReentrantReadWriteLock. readLock() doesn't block and won't be blocked unless something grabs the writeLock(). Would that help here? The swing thread seems to be reading, not writing. Edit: We still want to make sure we don't write concurrently, but...
Back
Top