Search results

+1 Ever the contrarian, I'm not sure about changing colors but it looks like that has already been done so...

That was awkward. I had a breakpoint where I thought a weapon had been selected. I had another where the equip command was emitted. The first fired as expected. The second didn't. So now I have to figure out the execution path and decide whether there is unnoticed or unexpected code keeping...

BetweenBattle script rather than mafia? Seems like an edge case that doesn't always have a universal solution.

Cleaned up the PR. One failing, disabled, test that I want to understand. Everything else works as expected. The new tests are probably redundant but someone can ding me on that once it goes back for review :-) Boosts are not the thing to look at if you are speculating. Once I realized that...

Current thinking and tests and a PR may change. There are two obvious causes of the maximizer being run and failing to equip a weapon. One is that the maximizer did not select a weapon. I originally thought the "effective" keyword was involved but I no longer think so. I am pretty sure I do...

Well. There is a helper, getBoosts that reports what the maximizer recommends. It turns out it references a static member of maximizer and one of my tests was incorrectly constructed as a result. Curious.

The ash 2 parameter version calls an internal 5 parameter version with zeros for the price data meaning the max price is zero and the maximizer should not consider buying. The ash 4 parameter version calls an internal 5 parameter version that interprets the third parameter as zero as meaning...

My naïve preference is that if it is in the list then its presence means I can create it by pressing the link. I don't care what I have in inventory or elsewhere. When I have no adventures I feel 'cheated" when I am offered a link to create Shore Scrip. But it does seem clear that I want to...

Found and fixed the password hash. https://github.com/kolmafia/kolmafia/pull/2203 has a single passing test added that to the best of my ability demonstrates the Maximizer selecting and equipping a weapon. I am hoping for feedback. If that test is the best we can do in a test that doesn't...

No meaningful progress. I have no confidence that my tests are exercising the equip step and the cases where no weapon is recommended seem to be correct. I've gotten distracted by looking at the Equip requests. I have a test that passes when I run it alone and fails when I run it with other...

IIRC mirror will write everything that goes to the gCLI to a named file. This sounds like there is an adjustment that is correctly computed at login but incorrectly recomputed later. modtrace at login and after it is downgraded might tell us what. I think "modtrace liver" but I'm not certain...

To be clear, why it failed to equip turtle totem is in scope of what I am working on. "Wielding turtle totem..." is the success message related to generating and submitting the equip command so it is not even clear that there was a failure to equip in your log. Why it picked turtle totem and...

public void noWeaponIsTheRightAnswer() { String maxStr = "5item,meat,0.5initiative,0.1da 1000max,dr,0.5all res,1.5mainstat,-fumble,mox,0.4hp,0.2mp 1000max,3mp regen,0.25spell damage,1.75spell damage percent,2familiar weight,5familiar exp,10exp,5Mysticality experience percent"...

I believe I have seen exactly that case with a level one Pastamancer with Master of the Surprising Fist. If that is indeed the case - to be assessed when today's run finishes - then I will try it as a test. I will also note that my understanding is evolving. I have seen examples where the...

This is only necessary for scripts that were hosted on GitHub but accessed via SVN. That doesn't seem to be the case so "svn update" should work as it always has. Further investigation or a Bug Report might be appropriate if svn update is not behaving. You might be interested in the gCLI...

Alas no failures to equip today so my added instrumentation did not find The Smoking Gun. More static analysis today and a hope for a new ascension tomorrow which, in the past, has triggered several failures. Tangentially there were several cases where autoscend missed an opportunity to do...

Well yesterday was a bust. My supposed failing tests turned out to fail because the test code didn't actually require the Maximizer to equip anything. My new tests all work. There is an internal parameter that controls whether things are to be equipped, or not, so an obvious path is to find...

Link will not work for me. It demands a Discord login which I do not have and am not willing to create in order to view the content. Would you consider copying the relevant information here or take a stab at fixing it yourself? Thank you.

Because public pronouncements are a way of keeping me accountable, at least to myself... There are circumstances when using the effective keyword will result in not selecting and equipping a weapon and that is the right answer. However there is definitely a bug where the user expects the...

By design the test speculates. I supposedly changed that so it equips and the recommendation is nothing but buffs. I'll stop reporting miniscule steps in progress but there is definitely something going on besides "effective".