Search results

Well... I decided to run the coverage reports locally since that was a quick way to find out whether the lines referenced above were executed or not. The Deck test has failed locally twice now. Go figure and stand by.

I never ran headless but once upon a time saw the deadlock a lot running with the GUI. Since my confidence level is related to tests passing/failing it is worth looking at the Deck test to see whether headless/Swing could be a factor. April 1 was an arbitrary deadline anyway. Thanks.

For reference see https://github.com/kolmafia/kolmafia/pull/1889 #1889 was a solution to preference file corruption. It appeared to address the issue so it was committed. But real world experience indicated a lot of deadlocks started occurring including one that occurred fairly consistently...

Thank you. I forgot log was there when I committed. I was failing to launch Kolmafia, could not figure out why and log captured STDOUT and STDERR from the process I launched. My mistake was in how I set up the command to run in ProcessBuilder.

New version - it does a lot of what I hoped for here. First it downloads the latest version of itself and restarts using that. It deletes older versions of itself. If the local Java version is too low for mafia it reports that and stops. Otherwise it will download the latest version of...

Hit a break point. r64 should do what previous versions did and might fix something, but probably not. Some testing and I removed some jar files that were bundled but not needed and so the jar is much smaller. There are some case sensitive bugs I need to investigate. If I actually write a...

I got some tests written and working. A side effect was that I am parsing Json in at least one place instead of using a mix of indedOf and substring. I was searching for something, could not find it and could not figure out how my search differed from what was in the file so I gave up and used...

I am writing tests. Might take a couple of days since I think I will have to relearn how to Mock classes and I know I need to make and use the equivalent of KoLmafia's root - KoLmafia/test/root Once I have tests I am going to return to some of the issues reported above. I will also consider...

Multitool's origin story is rooted in an attempt allow a user to determine whether their current version of Java was sufficient to run KoLmafia. That was me reacting to the Java nag PR. gausie suggested it could download and launch KoLmafia and that was easy to add. But now that the launcher...

I didn't use a record because I was too lazy (there's that word again) to see when they were introduced but not using one was easier than looking it up. I just got a KoLmafia test working so am resting on my laurels momentarily. multitool is not especially robust in the sense of detecting and...

*snicker* I'm fundamentally lazy, don't multi-task well and this never stays at the top of my queue for very long. Working on it is also a reminder of how far my skills and knowledge are from the current state of the art ;-) I'd love tests. I had not done them yet because I'm not sure I am...

New version. I now attempt to ignore local files that don't match the expected name convention which is ToolName-version-M.jar or ToolName-version.jar. I need to look at your failure to launch report. Any chance the multitool log file has something? I may also have incorrectly detected how...

Thank you again. I do not multi-task well and am focused on writing a document for real life and a KoLmafia test but this is next on the list.

Thank you. I'm glad there is developing interest. The existing code depends upon mafia jar file names following a convention. That should be documented, failure to adhere to the convention should be detected and ultimately dealt with constructively.

Are you telling me that once I hit the org.gradle.internal section I can safely ignore what follows and stop scrolling? I confess I had not figured that out but if true, it addresses my problems. Thanks.

See https://github.com/kolmafia/kolmafia/actions/runs/13764021050/job/38486242663?pr=2813 The stack traces that begin with "org.gradle.internal" tell me nothing about the test failure. The sheer number of them make it hard to figure out what the actual problem was. My recollection is that it...

I extracted the test from the "original" PR https://github.com/kolmafia/kolmafia/pull/1889 and included it in a PR that just had the test. https://github.com/kolmafia/kolmafia/pull/2813 My hypothesis was that if the test passed after https://github.com/kolmafia/kolmafia/pull/2808 had been...

Merged second report with first.

Does this make https://github.com/kolmafia/kolmafia/pull/1889 OBE? If yes then we should probably close it after confirming that using the Deck of Every Card does not trigger a race condition. If no or not sure then maybe an effort to confirm the presence or absence of Deck issue in 1889 would...

The original PR has been committed after some modification. Some of the issues raised or alternatives discussed have been implemented in the soon to be renamed multitool which is discussed elsewhere.