Search results

The tests should go. I think the only still-in-use scripts hosted on GitHub but using SVN are Ezandora's, and she updated her scripts after I broke everything with the modifiers change, so I expect come January she'll also fix them for the SVN thing. If not I'll make some forks.

Parsing changed in https://github.com/kolmafia/kolmafia/pull/94 and I wonder if it broke then.

Thanks, r27700.

It's probably the tiebreaker. Try running again with "-tie".

I don't see any reason in the code why "EA: none" wouldn't work. The other problem with expected_damage() is that it hasn't been updated to the new paradigm where monsters can have multiple attack elements. It assumes that the last "EA:" attribute is the sole attack element of the monster...

Should be fixed with r27685

Just to confirm this: the way it used to work is that if you cast the "today" skill before casting 5 skills total, it didn't count against the 5 casts, but if you tried to cast it after you'd already cast 5 other skills, it couldn't be cast. Now the behaviour is that in-run, whether a skill is...

check standard.php / your charsheet: does Long Winter's Nap appear in either? both? At one point this was fixed; it may have been unfixed.

If you type "/goto backoffice.php?pwd='+pwdhash+'&action=addbudget&meat=5" into the in-game chat, that will work. The Mafia version doesn't work because: pwd='+pwdhash+' is wrong: it should just be pwd access to backoffice.php is blocked.

Thanks for the report: should be fixed in r27654.

The other part of this is that (when it's a combat skill) sometimes we fire "addAvailableSkill" and sometimes "addAvailableCombatSkill". The former recalculates modifiers and the latter doesn't. I am curious as to whether we could just always use the latter.

I tried jamming in some recalculateAdjustments while looking at https://kolmafia.us/threads/mafia-setting-timesrested-to-0-on-login.29268/, but I never managed to make it work. If it works in the place you've got it, that's good to go, I think.

A side issue is that, after modtrace recalculates your adjustments, the sidepane still shows the previous value -- it needs a KoLCharacter.updateStatus() call to update.

I posted some investigation in https://kolmafia.us/threads/missing-1-drunk-capacity-starting-with-27601.29257/ -- there's a race condition to do with the passive skill cache. I don't know whether this is the root cause, but it might be.

Okay, so somebody else reported this (from after freeing the king), so I did some investigation and found the following, copied here for ease of reference: yeah, I can see a race `Modifiers.availablePassiveSkillModifiersByVariable` is cleared by `resetModifiers` which is called by...

This is the same way that the Baby Mutant Rattlesnake works, yes? So the existing Mafia modifier should be fine.

This is the inverse of https://kolmafia.us/threads/mafia-setting-timesrested-to-0-on-login.29268/, but I still haven't figured out how to get it to work correctly.

Okay, so it looks like whether free rests are available is updated for Chateau or Campground rests, but not Campaway rests. I can look into adding that.

The compact side pane bug is different (though it looks similar) -- I think the fix for that one just wants a "KoLCharacter.updateStatus()" call after the session is initialized. This one is about modifiers being computed incorrectly at first login.

I ran through some tests with ASH: have_skill and item_amount return the right values, but inebriety_limit returns the wrong one -- until the first recalculateAdjustments (e.g. "modtrace liver capacity" will do one -- though that also adds debug behaviour). I tried adding some...