Recent content by MCroft

  1. MCroft

    Feature - Implemented Something to automatically prune git history

    I am not a GIT professional. It was the future when I was a version control professional. But this is what I found. You have to separate fetch from pull and fetch with the prune command. Or I've misread it, but it looks like it's all done in the rebase function. Running this code now, it...
  2. MCroft

    Feature - Implemented Something to automatically prune git history

    Codewise, it's easy. For "clone", it's one line in GitManager.java. I think update will work fine if we initially got a sparse clone If you want a preference, or metadata about each file (you may want a full copy of your code but not mine), or other UI enhancements is up to you to figure out...
  3. MCroft

    Feature - Implemented Something to automatically prune git history

    So, if I guess correctly, there are two classes of users: end users want to get the latest, or perhaps a particular tag or revision, and no history. They are using git to get the latest version only and don't really interact with it in most git contexts. developer uses want to work on the code...
  4. MCroft

    Bug - Fixed Script execution aborted (java.lang.ArithmeticException: / by zero): (auto_util.ash, line 425)

    Well, it's a division by zero error, which is fair. Two Three questions: 1: What is the maximizer string that it's trying to satisfy? 2: What McHugeLarge items do you have in inventory? 3: Did you mark this as fixed yourself? The last question I'm asking because I don't see any change to the...
  5. MCroft

    New Content Hat Trick Challenge Path

    greycat also spaded wearing two outfits at once. I'm not sure what I expected, but I don't think it was exactly this. OTOH, I'm glad we don't have to fix maximizer for possible two outfits at once.
  6. MCroft

    New Content Hat Trick Challenge Path

    Should be able to check that. You just need an outfit that doesn't use pants to go with harem girl.
  7. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    effective won't allow a toy accordion for a weapon for a Seal Clubber. Test: public void musEffectiveIgnoresTwoHandedRangedWeapon() { String maxStr = "effective"; var cleanups = new Cleanups( withStats(25, 17, 20), withEquippableItem("Toy Accordion"), withSkill("tricky knifework") //...
  8. MCroft

    trivialskills: Automate casting the "trivial" skills

    I think I've brought it in as a string and used if (! is_integer(parameter) ) {} to display the help if the parameter isn't an int, but lots of options work. They're not-super-well documented on the ash wiki and hard to find. Also, there's no ASH version, it's a CLI...
  9. MCroft

    trivialskills: Automate casting the "trivial" skills

    very nice, but I'm having problems with it because I'm in a path that doesn't support permed skills. > trivialskills help Saving outfit: Backup Outfit saved Taking off candy cane sword cane... Equipment changed. Holding April Shower Thoughts shield... Equipment changed. Cast each trivial skill...
  10. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    I will take you up on that review offer, assuming I get anywhere with the code. Based on a combination of the code and reading some old threads here, it does two things. 1: It allows users with the skill tricky knife work to consider knives as ranged weapons. 2: It gives a single, stat-based...
  11. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    @fronobulax I am not convinced effective is more than a marginally useful keyword for large, general purpose scripts, nor that the benefit of allowing tricky knife work is worth the effort to use it. But I have often found that what seems reasonable to me is not how many others use the tool...
  12. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    First, that's a great model and it tests things like I expect. This is my draft test to show that it selects an offhand and none. If we adjust "effective" to have allow the non-preferred type (melee/ranged) if the "effective" type is an empty list, this is how I'd want to test it. Honestly...
  13. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    This is actually in Kolmafia and KoL Nothing + offhand is valid for KoL, as long as the offhand isn't a weapon. It's not looking at them as accessories. It's reusing the slot to save on memory. Accessories are pulling the first three items from SLOT ACCESSORY1. That's not broken (that I know...
  14. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    I am down for that discussion. I don't think we've seen any complaints about this with WotSF, but we might not, since WotSF doesn't allow offhand or weapons to be equipped at all. But let's dig into my 20250217 log (from this previous post (full logs and inventory listed above)). Here's the...
  15. MCroft

    Bug - Confirmed Maximizer didn't equip a weapon

    I didn't find where it should take care of that case, but it looks like in the past evaluator.java was supposed to be aware of it. It may be that it sometimes is and there's an edge case. I'm looking to see if there's an obvious place to say "offhand value=0 if weapon=null", but no one should...
Back
Top